Bug 104903 - Web Inspector: Native Memory Instrumentation: do not validate pointers to objects in RenderArena agains tcmalloc data
Summary: Web Inspector: Native Memory Instrumentation: do not validate pointers to obj...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-13 04:27 PST by Ilya Tikhonovsky
Modified: 2012-12-13 06:24 PST (History)
13 users (show)

See Also:

Attachments
Patch (9.68 KB, patch)
2012-12-13 04:35 PST, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
comments addressed (10.55 KB, patch)
2012-12-13 06:19 PST, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-12-13 04:27:07 PST 
EOM
Comment 1 Ilya Tikhonovsky 2012-12-13 04:35:27 PST 
Created attachment 179250 [details]
Patch
Comment 2 Yury Semikhatsky 2012-12-13 05:21:03 PST 
I think we should rename the method to something like setCustomAllocation or setNotMalloced as Arena may be too specific allocator.
Comment 3 Build Bot 2012-12-13 05:23:57 PST 
Comment on attachment 179250 [details]
Patch

Attachment 179250 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15311231
Comment 4 Ilya Tikhonovsky 2012-12-13 06:19:53 PST 
Created attachment 179262 [details]
comments addressed
Comment 5 Yury Semikhatsky 2012-12-13 06:22:04 PST 
Comment on attachment 179262 [details]
comments addressed

View in context: https://bugs.webkit.org/attachment.cgi?id=179262&action=review

> Source/WTF/wtf/MemoryObjectInfo.h:62
> +    void setCustomAllocation(bool customAllocation) { m_customAllocation = customAllocation; }

Are we ever going to call this with customAllocation = false ?
Comment 6 Ilya Tikhonovsky 2012-12-13 06:24:51 PST 
Committed r137589: <http://trac.webkit.org/changeset/137589>