Bug 104902 – Web Inspector: "Add Attribute" context menu on closing tag should apply on the opening tag on Elements Panel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Vivek Galatage]

Web Inspector: "Add Attribute" context menu shouldn't appear on closing tag on Elements Panel.

Steps:
1. Open any page with inspector open
2. Navigate to Elements panel
3. Expand some nodes so you can view the closing tag separately
4. Perform action (right click for linux/windows) to open context menu on the Closing Tag.
5. "Add Attribute" context menu item is shown
6. Go ahead with adding some attribute value
7. The attribute is seen even on the closing tag
e.g. <div id="test">
         ...
     </div id="test">

Expected:
The "Add Attribute" on a closing tag shouldn't be shown

Patch to follow.

[Vivek Galatage]

Created attachment 179247 [details]
Patch

[Alexander Pavlov (apavlov)]

Perhaps, instead of forbidding to add attributes on the closing tag, we might automatically add them to the opening tag? If |this| is the closing tag, you can bind this._addNewAttribute() to the opening tag using this.findTreeElement(this.representedObject), something like this:

contextMenu.appendItem(..., this._addNewAttribute.bind(this._elementCloseTag ? this.treeOutline.findTreeElement(this.representedObject) : this));

[Vivek Galatage]

Created attachment 179252 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 179252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179252&action=review

The code looks good, just a minor ChangeLog fix is needed.

> Source/WebCore/ChangeLog:8
> +        The context menu action on the Closing Tag takes to the Opening tag for adding the attribute.

There should be no caps in the middle of the sentence. Also, "takes" -> "scrolls to"

> Source/WebCore/ChangeLog:10
> +        No new tests as UI tweak.

No new tests, as this is a UI change.
(I've seen a guideline somewhere that imposes the use of common English rather than slang-ish/ambiguous terms, like "tweak".)

[Vivek Galatage]

Created attachment 179264 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 179264 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 179264 [details]
Patch

Clearing flags on attachment: 179264

Committed r137594: <http://trac.webkit.org/changeset/137594>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.