Bug 104900 – Web Inspector: Link to documentation of CSS properties

• Status: ASSIGNED
• Component: Web Inspector

[Alexander Pavlov (apavlov)]

It would be useful to open the W3C spec corresponding to CSS properties e.g. from the context menu of property name elements in the Styles sidebar pane.

Upstreaming https://code.google.com/p/chromium/issues/detail?id=163316

[Alexander Pavlov (apavlov)]

Created attachment 179259 [details]
Patch

[Pavel Feldman]

Comment on attachment 179259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179259&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:33
> + * @implements {WebInspector.ContextMenu.Provider}

Only use ContextMenu.Provider on generic targets. UISourceCode, etc. In other cases simply create and populate it by hand.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:165
> +        var url = WebInspector.StylesSidebarPane.W3OrgData.getHelpURL(propertyName);

No get prefixes in WebKit plz.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:2617
> +WebInspector.StylesSidebarPane.W3OrgData = {}

Does not look like a good idea to increase file size from 2600 lines to 2900. Extract?

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:2623
> +WebInspector.StylesSidebarPane.W3OrgData.getHelpURL = function(propertyName)

Here and below: no get prefixes please.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:2706
> +    "color": { m: "color", a: "foreground" },

Please don't create new metainfo on the properties - we already have WebInspector.CSSKeywordCompletions that you could annotate with spec info.

[Radar WebKit Bug Importer]

<rdar://problem/19192139>