Bug 104899 - Web Inspector: Network: display JavaScript stack in case of script initiator.
Summary: Web Inspector: Network: display JavaScript stack in case of script initiator.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on: 104992
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-13 03:41 PST by Eugene Klyuchnikov
Modified: 2012-12-18 02:04 PST (History)
11 users (show)

See Also:

Attachments
Patch (5.44 KB, patch)
2012-12-14 00:26 PST, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Screenshot (38.26 KB, image/png)
2012-12-14 01:57 PST, Eugene Klyuchnikov 		no flags Details
Patch (5.88 KB, patch)
2012-12-14 01:59 PST, Eugene Klyuchnikov 		pfeldman: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2012-12-13 03:41:48 PST 
We could either display it on hover or in a separate Network tab.
RE: It would also be awesome if the stack trace was clickable back to the javascript sources, in the sources panel.

Original issue: http://code.google.com/p/chromium/issues/detail?id=155300
Comment 1 Eugene Klyuchnikov 2012-12-14 00:26:30 PST 
Created attachment 179438 [details]
Patch
Comment 2 Pavel Feldman 2012-12-14 00:50:33 PST 
A screenshot please?
Comment 3 Vsevolod Vlasov 2012-12-14 00:52:31 PST 
Is it clickable? The timeline popover is not clickable right now.
Comment 4 Eugene Klyuchnikov 2012-12-14 01:57:37 PST 
Created attachment 179450 [details]
Screenshot
Comment 5 Eugene Klyuchnikov 2012-12-14 01:59:06 PST 
Created attachment 179451 [details]
Patch

Use-standard-timeout
Comment 6 Pavel Feldman 2012-12-14 02:00:15 PST 
Comment on attachment 179451 [details]
Patch

We want almost instant feedback here.
Comment 7 Vsevolod Vlasov 2012-12-14 02:04:32 PST 
I think it should appear almost immediately, but disappear after a longer timeout.
Comment 8 Pavel Feldman 2012-12-14 02:13:18 PST 
(In reply to comment #7)
> I think it should appear almost immediately, but disappear after a longer timeout.

As of today, Popover is designed in a way that the timeout before showing popover must be bigger than the one for hiding it. Changing it will require some popover rework. But we could try doing that.
Comment 9 Vsevolod Vlasov 2012-12-17 03:52:56 PST 
Comment on attachment 179438 [details]
Patch

We should either support show timeout being shorter than hide timeout or use different popover helper for initiator. This implementation is not clickable which does not make much sense to me.
Comment 10 Eugene Klyuchnikov 2012-12-18 01:35:13 PST 
Comment on attachment 179438 [details]
Patch

Popover behavior has been changed. PTAL
Comment 11 WebKit Review Bot 2012-12-18 02:04:25 PST 
Comment on attachment 179438 [details]
Patch

Clearing flags on attachment: 179438

Committed r138000: <http://trac.webkit.org/changeset/138000>
Comment 12 WebKit Review Bot 2012-12-18 02:04:30 PST 
All reviewed patches have been landed.  Closing bug.