Bug 104893 – Web Inspector: Network: Sorting cookies by size is broken.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Eugene Klyuchnikov]

Steps to reproduce the problem:
1. In devtools, open a network request with some request cookies.
2. click on header of the size column to sort by size

What is the expected behavior?
The cookies should be sorted by size.

What went wrong?
A couple of the cookies bounce around when the column is clicked, but they are definitely not sorted.

Original issue: http://code.google.com/p/chromium/issues/detail?id=165571

[Eugene Klyuchnikov]

Created attachment 179236 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 179236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179236&action=review

> Source/WebCore/ChangeLog:8
> +        Problem: cookie "size" is not a field now; its value is accesible

accessible

> Source/WebCore/ChangeLog:11
> +        Solution: make cookie fields uniformly accesible (add getters for name,

ditto

[Eugene Klyuchnikov]

Comment on attachment 179236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179236&action=review

>> Source/WebCore/ChangeLog:8
>> +        Problem: cookie "size" is not a field now; its value is accesible
> 
> accessible

Done.

>> Source/WebCore/ChangeLog:11
>> +        Solution: make cookie fields uniformly accesible (add getters for name,
> 
> ditto

Fixed.

[Eugene Klyuchnikov]

Created attachment 179244 [details]
Patch

[WebKit Review Bot]

Comment on attachment 179244 [details]
Patch

Clearing flags on attachment: 179244

Committed r137585: <http://trac.webkit.org/changeset/137585>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Beth Dakin]

This change caused http/tests/inspector/resource-main-cookies.php to start failing on the Mac. Can you please tell me if this test is now broken or if it needs updated results?

http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r137585%20(4718)/http/tests/inspector/resource-main-cookies-pretty-diff.html

[Beth Dakin]

(In reply to comment #7)
> This change caused http/tests/inspector/resource-main-cookies.php to start failing on the Mac. Can you please tell me if this test is now broken or if it needs updated results?
> 
> http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r137585%20(4718)/http/tests/inspector/resource-main-cookies-pretty-diff.html

I filed https://bugs.webkit.org/show_bug.cgi?id=104977