Bug 104889 - [QT][GTK][EFL] Add guard for WebInspectorServer
Summary: [QT][GTK][EFL] Add guard for WebInspectorServer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-13 01:00 PST by Seokju Kwon
Modified: 2012-12-13 17:11 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2012-12-13 05:39 PST, Seokju Kwon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2012-12-13 01:00:04 PST 
Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer.
Comment 1 Seokju Kwon 2012-12-13 05:39:13 PST 
Created attachment 179255 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-12-13 15:40:07 PST 
Comment on attachment 179255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179255&action=review

> Source/WebKit2/ChangeLog:9
> +
> +        Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer.
> +

Are you sure that is defined by default by all these ports?
Comment 3 Seokju Kwon 2012-12-13 15:42:21 PST 
(In reply to comment #2)
> (From update of attachment 179255 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179255&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +
> > +        Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer.
> > +
> 
> Are you sure that is defined by default by all these ports?

in Source/WebKit2/config.h

#ifndef ENABLE_INSPECTOR_SERVER
#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(EFL)
#define ENABLE_INSPECTOR_SERVER 1
#endif
#endif
Comment 4 WebKit Review Bot 2012-12-13 17:11:32 PST 
Comment on attachment 179255 [details]
Patch

Clearing flags on attachment: 179255

Committed r137687: <http://trac.webkit.org/changeset/137687>
Comment 5 WebKit Review Bot 2012-12-13 17:11:35 PST 
All reviewed patches have been landed.  Closing bug.