RESOLVED FIXED 104889
[QT][GTK][EFL] Add guard for WebInspectorServer 
https://bugs.webkit.org/show_bug.cgi?id=104889
Summary [QT][GTK][EFL] Add guard for WebInspectorServer
Seokju Kwon
Reported 2012-12-13 01:00:04 PST
Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer.
Attachments
Patch (2.86 KB, patch)
2012-12-13 05:39 PST, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Seokju Kwon
Comment 1 2012-12-13 05:39:13 PST
Created attachment 179255 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-12-13 15:40:07 PST
Comment on attachment 179255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179255&action=review > Source/WebKit2/ChangeLog:9 > + > + Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer. > + Are you sure that is defined by default by all these ports?
Seokju Kwon
Comment 3 2012-12-13 15:42:21 PST
(In reply to comment #2) > (From update of attachment 179255 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179255&action=review > > > Source/WebKit2/ChangeLog:9 > > + > > + Add ENABLE(INSPECTOR_SERVER) guard around platform-specific implementation for WebInspectorServer. > > + > > Are you sure that is defined by default by all these ports? in Source/WebKit2/config.h #ifndef ENABLE_INSPECTOR_SERVER #if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(EFL) #define ENABLE_INSPECTOR_SERVER 1 #endif #endif
WebKit Review Bot
Comment 4 2012-12-13 17:11:32 PST
Comment on attachment 179255 [details] Patch Clearing flags on attachment: 179255 Committed r137687: <http://trac.webkit.org/changeset/137687>
WebKit Review Bot
Comment 5 2012-12-13 17:11:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.