Bug 104888 – Web Inspector: collect native heap graph and report it to the front-end

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Now that memory instrumentation has API for reporting heap nodes and edges we can serialize the graph and send it to the front-end.

[Yury Semikhatsky]

Created attachment 179225 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 179225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179225&action=review

> Source/WebCore/inspector/HeapGraphSerializer.cpp:81
> +HeapGraphSerializer::HeapGraphSerializer()

HeapGraphSerializer -> HeapGraph

> Source/WebCore/inspector/HeapGraphSerializer.h:77
> +    typedef HashMap<String, int> StringMap;
> +    StringMap m_stringToIndex;
> +    Vector<String> m_strings;
> +    int m_lastReportedEdgeIndex;
> +
> +    typedef HashMap<const void*, int> ObjectToNodeIndex;
> +    ObjectToNodeIndex m_objectToNodeIndex;
> +
> +    typedef HashMap<const void*, const void*> BaseToRealAddress;
> +    BaseToRealAddress m_baseToRealAddress;
> +
> +    Vector<HeapGraphNode> m_nodes;
> +    Vector<HeapGraphEdge> m_edges;

please implement reportMemoryUsage method.

[Yury Semikhatsky]

Created attachment 179243 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 179225 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179225&action=review
> 
> > Source/WebCore/inspector/HeapGraphSerializer.cpp:81
> > +HeapGraphSerializer::HeapGraphSerializer()
> 
> HeapGraphSerializer -> HeapGraph
> 
I disagree, HeapGraphSerializer better reflects intent of the class which receives signals from the memory instrumentation and serializes them into a heap graph representation, it doesn't allow you to change the graph or read it.


> > Source/WebCore/inspector/HeapGraphSerializer.h:77
> > +    typedef HashMap<String, int> StringMap;
> > +    StringMap m_stringToIndex;
> > +    Vector<String> m_strings;
> > +    int m_lastReportedEdgeIndex;
> > +
> > +    typedef HashMap<const void*, int> ObjectToNodeIndex;
> > +    ObjectToNodeIndex m_objectToNodeIndex;
> > +
> > +    typedef HashMap<const void*, const void*> BaseToRealAddress;
> > +    BaseToRealAddress m_baseToRealAddress;
> > +
> > +    Vector<HeapGraphNode> m_nodes;
> > +    Vector<HeapGraphEdge> m_edges;
> 
> please implement reportMemoryUsage method.
Done.

[Ilya Tikhonovsky]

Comment on attachment 179225 [details]
Patch

lgtm

[Yury Semikhatsky]

Committed r137728: <http://trac.webkit.org/changeset/137728>