Bug 104876 - Add ASSERTions to ensure that when a CSSProperty is a variable it only ever refers to a CSSValue that is a variable.
Summary: Add ASSERTions to ensure that when a CSSProperty is a variable it only ever r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-12 21:02 PST by Luke Macpherson
Modified: 2012-12-17 21:36 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.94 KB, patch)
2012-12-12 21:10 PST, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch (1.94 KB, patch)
2012-12-17 19:14 PST, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch (1.94 KB, patch)
2012-12-17 19:40 PST, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-12-12 21:02:27 PST 
Add ASSERTions to ensure that CSSPropertys that are variables only ever refer to CSSValues that are variables.
Comment 1 Luke Macpherson 2012-12-12 21:10:01 PST 
Created attachment 179194 [details]
Patch
Comment 2 Steve Block 2012-12-12 21:52:53 PST 
Comment on attachment 179194 [details]
Patch

LGTM given that this is all behind ENABLE_CSS_VARIABLES
Comment 3 WebKit Review Bot 2012-12-12 22:16:11 PST 
Comment on attachment 179194 [details]
Patch

Clearing flags on attachment: 179194

Committed r137569: <http://trac.webkit.org/changeset/137569>
Comment 4 WebKit Review Bot 2012-12-12 22:16:14 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Kentaro Hara 2012-12-13 04:53:16 PST 
A bunch of CSS tests hit the ASSERTs:

css3/filters/reference-filter-update-after-remove.html
fast/css/variables/border-width.html
fast/css/variables/calc-inside-calc.html
fast/css/variables/calc-invalid-value.html
fast/css/variables/calc-negated-variable.html
fast/css/variables/calc-vw-crash.html
fast/css/variables/calc.html
fast/css/variables/case-insensitive.html
fast/css/variables/colors-test.html
fast/css/variables/complex-cycle.html
fast/css/variables/computed-style.html
fast/css/variables/deferred-image-load-from-variable.html
fast/css/variables/inherited-values.html
fast/css/variables/inline-styles.html
fast/css/variables/invalid-shorthand.html
fast/css/variables/invalid-variable-value.html
fast/css/variables/multi-level-cycle.html
fast/css/variables/redefinition.html
fast/css/variables/shorthand.html
fast/css/variables/simple-cycle.html
fast/css/variables/transform-test.html
fast/css/variables/use-before-defined.html
fast/css/variables/var-filter.html
fast/css/variables/var-inside-pair.html
fast/css/variables/var-inside-quad.html
fast/css/variables/var-inside-shape.html
fast/css/variables/var-inside-shorthand.html
fast/css/variables/variable-chain.html
inspector/styles/variables/css-variables.html
Comment 6 Kentaro Hara 2012-12-13 04:53:49 PST 
Rolled out the patch in r137584. Would you take a look?
Comment 7 Luke Macpherson 2012-12-13 15:04:48 PST 
(In reply to comment #6)
> Rolled out the patch in r137584. Would you take a look?

Absolutely. Thanks for rolling it out.
Comment 8 Luke Macpherson 2012-12-17 19:14:27 PST 
Created attachment 179859 [details]
Patch
Comment 9 Luke Macpherson 2012-12-17 19:40:39 PST 
Created attachment 179867 [details]
Patch
Comment 10 Steve Block 2012-12-17 20:10:45 PST 
Comment on attachment 179867 [details]
Patch

r=me
Comment 11 WebKit Review Bot 2012-12-17 21:36:40 PST 
Comment on attachment 179867 [details]
Patch

Clearing flags on attachment: 179867

Committed r137984: <http://trac.webkit.org/changeset/137984>
Comment 12 WebKit Review Bot 2012-12-17 21:36:44 PST 
All reviewed patches have been landed.  Closing bug.