Bug 104873 – Validity of a radio button is not updated correctly when it is detached from an invalid radio group

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

http://code.google.com/p/chromium/issues/detail?id=165464

<form>
  <input type=radio name=g required id=radio2> 
  <input type=radio name=g required id=radio3>
</form>

If we remove radio2 from the document tree, it should update validity state and should be valid. However it becomes invalid.

[Kent Tamura]

Created attachment 179192 [details]
Patch

[Kentaro Hara]

Comment on attachment 179192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179192&action=review

> Source/WebCore/html/HTMLInputElement.cpp:1776
> -bool HTMLInputElement::isInRequiredRadioButtonGroup() const
> +bool HTMLInputElement::isInRequiredRadioButtonGroup()

Why do you need to remove const ?

> Source/WebCore/html/HTMLInputElement.h:248
> -    bool isInRequiredRadioButtonGroup() const;
> +    bool isInRequiredRadioButtonGroup();

Ditto.

> LayoutTests/fast/forms/radio/radio-live-validation-style.html:37
> +shouldBeTrue('$("radio1").remove(); radio2.remove(); radio2.webkitMatchesSelector(":valid")');

You might want to also check that radio2.webkitMatchesSelector(":valid") is false before removing radio2.

[Kent Tamura]

Comment on attachment 179192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179192&action=review

>> Source/WebCore/html/HTMLInputElement.cpp:1776
>> +bool HTMLInputElement::isInRequiredRadioButtonGroup()
> 
> Why do you need to remove const ?

RadioButtonGroup::m_member is a HashSet<HTMLInputElement*>
⇨ RadioButtonGroup::contains needs non-const HTMLInputElement*.
⇨ CheckedRadioButtons::isInRequiredGroup needs non-const HTMLInputElement*.
⇨ HTMLInputElement::isInRequiredRadioButtonGroup needs to be non-const.

>> LayoutTests/fast/forms/radio/radio-live-validation-style.html:37
>> +shouldBeTrue('$("radio1").remove(); radio2.remove(); radio2.webkitMatchesSelector(":valid")');
> 
> You might want to also check that radio2.webkitMatchesSelector(":valid") is false before removing radio2.

will do

[Kentaro Hara]

(In reply to comment #3)
> > Why do you need to remove const ?
> 
> RadioButtonGroup::m_member is a HashSet<HTMLInputElement*>
> ⇨ RadioButtonGroup::contains needs non-const HTMLInputElement*.
> ⇨ CheckedRadioButtons::isInRequiredGroup needs non-const HTMLInputElement*.
> ⇨ HTMLInputElement::isInRequiredRadioButtonGroup needs to be non-const.

Makes sense. Thanks for the clarification.

[Kent Tamura]

Created attachment 179195 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 179195 [details]
Patch for landing

Clearing flags on attachment: 179195

Committed r137565: <http://trac.webkit.org/changeset/137565>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.