Bug 104871 - webkitpy: rename ResultSummary
Summary: webkitpy: rename ResultSummary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 103824
  Show dependency tree / graph
 
Reported: 2012-12-12 18:40 PST by Dirk Pranke
Modified: 2012-12-13 12:09 PST (History)
6 users (show)

See Also:

Attachments
Patch (65.65 KB, patch)
2012-12-12 18:46 PST, Dirk Pranke 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-12-12 18:40:06 PST 
webkitpy: rename ResultSummary
Comment 1 Dirk Pranke 2012-12-12 18:46:46 PST 
Created attachment 179179 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-12-12 19:26:13 PST 
Comment on attachment 179179 [details]
Patch

LGTM.
Comment 3 Dirk Pranke 2012-12-13 11:06:53 PST 
Committed r137621: <http://trac.webkit.org/changeset/137621>
Comment 4 Thiago Marcos P. Santos 2012-12-13 12:01:29 PST 
Bots are failing with this:

AttributeError raised: 'RunDetails' object has no attribute 'run_results'
Traceback (most recent call last):
  File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 410, in main
    bot_printer.print_results(run_details)
  File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py", line 51, in print_results
    self.print_run_results(run_details.run_results)
AttributeError: 'RunDetails' object has no attribute 'run_results'
Failed to execute Tools/Scripts/new-run-webkit-tests at ./Tools/Scripts/run-webkit-tests line 126.
Comment 5 Dirk Pranke 2012-12-13 12:09:44 PST 
Yeah, sorry. Fixed in http://trac.webkit.org/changeset/137634 (missed one variable rename; the patch adds a test for it).