Bug 104868 - [Resource Timing] Don't report resources with data: urls
Summary: [Resource Timing] Don't report resources with data: urls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Simonsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-12 17:49 PST by James Simonsen
Modified: 2012-12-13 16:14 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.79 KB, patch)
2012-12-12 17:49 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
Patch for landing (4.89 KB, patch)
2012-12-13 15:21 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Simonsen 2012-12-12 17:49:24 PST 
[Resource Timing] Don't report resources with data: urls
Comment 1 James Simonsen 2012-12-12 17:49:51 PST 
Created attachment 179165 [details]
Patch
Comment 2 Tony Gentilcore 2012-12-13 12:20:42 PST 
Comment on attachment 179165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179165&action=review

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:709
> +    if (resource && !resource->errorOccurred() && !resource->wasCanceled() && resource->response().isHTTP()) {

Does this include HTTPS as well?
Comment 3 James Simonsen 2012-12-13 13:58:15 PST 
(In reply to comment #2)
> (From update of attachment 179165 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179165&action=review
> 
> > Source/WebCore/loader/cache/CachedResourceLoader.cpp:709
> > +    if (resource && !resource->errorOccurred() && !resource->wasCanceled() && resource->response().isHTTP()) {
> 
> Does this include HTTPS as well?

Yep.
Comment 4 James Simonsen 2012-12-13 15:21:40 PST 
Created attachment 179353 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-12-13 16:14:23 PST 
Comment on attachment 179353 [details]
Patch for landing

Clearing flags on attachment: 179353

Committed r137677: <http://trac.webkit.org/changeset/137677>
Comment 6 WebKit Review Bot 2012-12-13 16:14:27 PST 
All reviewed patches have been landed.  Closing bug.