This follows the fix for Qt in https://bugs.webkit.org/show_bug.cgi?id=60206.
Created attachment 179230 [details] Patch
looks good to me.
Does this work on Mac now? If if does, why do we need to change cross-platform code?
The test is still skipped on Mac. On reflection, my patch should probably unskip the test on all platforms. Assuming that one platform handles this properly, is it still better to repeat the logic in all n-1 WebKit layers or to wrap the code in an #ifdef?
Well, if Mac already handles this properly, my question would be how it does that, and whether it's better design. I haven't thought about this patch deeply.
I think comment https://bugs.webkit.org/show_bug.cgi?id=60206#c6 is relevant for discussing this bug.
Indeed!
Looks reasonable to me. Someone who recently worked on this code should probably do final review. Can you unskip the test on other platforms, to let Mac EWS run the test? Please also consider duping to the older bug.
Created attachment 180623 [details] Patch
*** Bug 60206 has been marked as a duplicate of this bug. ***
Thanks for the comments. I uploaded a new patch unskipping this test everywhere, except WebKit2. For WebKit2 the TestExpectations comments suggested there is still more work to do on testRunner.queueLoad. I've also marked 60206 a duplicate of this bug.
> I've also marked 60206 a duplicate of this bug. Why not the other way around? It's normally advisable to keep an older bug.
(In reply to comment #12) > > I've also marked 60206 a duplicate of this bug. > > Why not the other way around? It's normally advisable to keep an older bug. I usually dupe the ones that don't have a patch, but I'm happy to upload the patch at the other bug and mark this one as the duplicate.
*** This bug has been marked as a duplicate of bug 60206 ***
Comment on attachment 180623 [details] Patch Cleared review? from attachment 180623 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).