Bug 104865 - Handle HTTP 204 status codes in MainResourceLoader
Summary: Handle HTTP 204 status codes in MainResourceLoader
Status: RESOLVED DUPLICATE of bug 60206
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-12 17:17 PST by Martin Robinson
Modified: 2013-01-04 00:56 PST (History)
8 users (show)

See Also:


Attachments
Patch (6.92 KB, patch)
2012-12-13 01:47 PST, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (9.27 KB, patch)
2012-12-23 09:13 PST, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-12-12 17:17:09 PST
This follows the fix for Qt in https://bugs.webkit.org/show_bug.cgi?id=60206.
Comment 1 Martin Robinson 2012-12-13 01:47:01 PST
Created attachment 179230 [details]
Patch
Comment 2 Laszlo Gombos 2012-12-17 16:49:52 PST
looks good to me.
Comment 3 Alexey Proskuryakov 2012-12-17 16:57:54 PST
Does this work on Mac now? If if does, why do we need to change cross-platform code?
Comment 4 Martin Robinson 2012-12-17 21:39:33 PST
The test is still skipped on Mac. On reflection, my patch should probably unskip the test on all platforms. Assuming that one platform handles this properly, is it still better to repeat the logic in all n-1 WebKit layers or to wrap the code in an #ifdef?
Comment 5 Alexey Proskuryakov 2012-12-17 22:01:29 PST
Well, if Mac already handles this properly, my question would be how it does that, and whether it's better design. I haven't thought about this patch deeply.
Comment 6 Laszlo Gombos 2012-12-18 18:42:30 PST
I think comment https://bugs.webkit.org/show_bug.cgi?id=60206#c6 is relevant for discussing this bug.
Comment 7 Alexey Proskuryakov 2012-12-18 19:33:28 PST
Indeed!
Comment 8 Alexey Proskuryakov 2012-12-18 20:27:34 PST
Looks reasonable to me. Someone who recently worked on this code should probably do final review.

Can you unskip the test on other platforms, to let Mac EWS run the test? Please also consider duping to the older bug.
Comment 9 Martin Robinson 2012-12-23 09:13:22 PST
Created attachment 180623 [details]
Patch
Comment 10 Martin Robinson 2012-12-23 09:14:45 PST
*** Bug 60206 has been marked as a duplicate of this bug. ***
Comment 11 Martin Robinson 2012-12-23 09:16:35 PST
Thanks for the comments. I uploaded a new patch unskipping this test everywhere, except WebKit2. For WebKit2 the TestExpectations comments suggested there is still more work to do on testRunner.queueLoad. I've also marked 60206 a duplicate of this bug.
Comment 12 Alexey Proskuryakov 2012-12-25 19:52:51 PST
> I've also marked 60206 a duplicate of this bug.

Why not the other way around? It's normally advisable to keep an older bug.
Comment 13 Martin Robinson 2012-12-25 21:10:54 PST
(In reply to comment #12)
> > I've also marked 60206 a duplicate of this bug.
> 
> Why not the other way around? It's normally advisable to keep an older bug.

I usually dupe the ones that don't have a patch, but I'm happy to upload the patch at the other bug and mark this one as the duplicate.
Comment 14 Martin Robinson 2012-12-27 10:27:41 PST

*** This bug has been marked as a duplicate of bug 60206 ***
Comment 15 Eric Seidel (no email) 2013-01-04 00:56:37 PST
Comment on attachment 180623 [details]
Patch

Cleared review? from attachment 180623 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).