Bug 104863 – Check whether a touchDown lands on a registered touch event handler from the compositor

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

Check whether a touchDown lands on a registered touch event handler from the compositor

Created attachment 179156 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Comment on attachment 179156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179156&action=review

> Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:61
> +    MOCK_METHOD1(haveTouchEventHandslersAt, bool(WebPoint));

you don't need to add this unless you're adding a test that uses the mock, FYI

[WebKit Review Bot]

Comment on attachment 179156 [details]
Patch

Attachment 179156 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15311031

Created attachment 179164 [details]
Patch

Created attachment 179167 [details]
Patch

I (In reply to comment #3)
> (From update of attachment 179156 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179156&action=review
> 
> > Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:61
> > +    MOCK_METHOD1(haveTouchEventHandslersAt, bool(WebPoint));
> 
> you don't need to add this unless you're adding a test that uses the mock, FYI

I just realized I need it because I am adding that function to WebInputHandlerClient as a pure virtual. I had misspelled the function name before.

[James Robinson]

Comment on attachment 179167 [details]
Patch

Ah indeed. R still = me

Created attachment 179176 [details]
Patch

[James Robinson]

Comment on attachment 179176 [details]
Patch

Seems like the same patch as before?

Sorr(In reply to comment #10)
> (From update of attachment 179176 [details])
> Seems like the same patch as before?

Sorry the if was missing a !.

[WebKit Review Bot]

Comment on attachment 179176 [details]
Patch

Rejecting attachment 179176 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 159 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
52>At revision 159.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15312322

[James Robinson]

ChangeLog has some minor issues - I'll fix and land by hand.

[James Robinson]

Committed r137616: <http://trac.webkit.org/changeset/137616>