Bug 104862 – "loader_unittests should reset state between runs"

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Julie Parent]

"loader_unittests should reset state between runs"

[Julie Parent]

Created attachment 179152 [details]
Patch

[Dirk Pranke]

Comment on attachment 179152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179152&action=review

seems reasonable.

> Tools/TestResultServer/static-dashboards/loader_unittests.js:91
> +    parseCrossDashboardParameters();

was the parseCrossDashboardParameters() line meant to be part of this?

[Julie Parent]

Yeah, parseCrossDashboardParameters() was intentional.  One of the other tests calls it, and this test was depending on the modifications to global variables that parseCrossDashboardParameters made (and of course, to that other test running before this one!!!).  Once I added the call to resetGlobals(), that state was getting reset, so this test needs to explicitly call it

[Dirk Pranke]

(In reply to comment #3)
> Yeah, parseCrossDashboardParameters() was intentional.  One of the other tests calls it, and this test was depending on the modifications to global variables that parseCrossDashboardParameters made (and of course, to that other test running before this one!!!).  Once I added the call to resetGlobals(), that state was getting reset, so this test needs to explicitly call it

Yeah, sorry, I figured that out after looking at the code but forgot to delete the comment.

[WebKit Review Bot]

Comment on attachment 179152 [details]
Patch

Rejecting attachment 179152 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

/mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15312045

[Julie Parent]

Created attachment 179279 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 179279 [details]
Patch for landing

Clearing flags on attachment: 179279

Committed r137599: <http://trac.webkit.org/changeset/137599>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ojan Vafai]

Comment on attachment 179279 [details]
Patch for landing

Hopefully we can get rid of this once Loader no longer uses any globals?