Bug 104856 - rework ChromiumAndroidDriver.start() et. al to avoid funky layering
Summary: rework ChromiumAndroidDriver.start() et. al to avoid funky layering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-12 16:00 PST by Dirk Pranke
Modified: 2012-12-12 17:59 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2012-12-12 16:07 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-12-12 16:00:49 PST 
rework ChromiumAndroidDriver.start() et. al to avoid funky layering
Comment 1 Dirk Pranke 2012-12-12 16:07:46 PST 
Created attachment 179141 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-12-12 16:14:45 PST 
Comment on attachment 179141 [details]
Patch

I'll test your patch locally and report back.
Comment 3 Eric Seidel (no email) 2012-12-12 16:28:19 PST 
Comment on attachment 179141 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2012-12-12 17:59:18 PST 
Comment on attachment 179141 [details]
Patch

Clearing flags on attachment: 179141

Committed r137550: <http://trac.webkit.org/changeset/137550>
Comment 5 WebKit Review Bot 2012-12-12 17:59:22 PST 
All reviewed patches have been landed.  Closing bug.