Bug 104851 – Expose crypto.getRandomValues to Web Workers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ryan Sleevi]

As per the latest W3C Web Crypto Editor's Draft, window.crypto.getRandomValues should be exposed to workers via the WorkerCrypto interface - http://dvcs.w3.org/hg/webcrypto-api/raw-file/f5e8d9a3e18f/spec/Overview.html#WorkerCrypto-interface

[Alexey Proskuryakov]

It doesn't look like Ryan is working on this, unassigning.

[Adam Lippai]

With the FF48 release Safari is the last browser not supporting WebCrypto in web workers.

[Radar WebKit Bug Importer]

<rdar://problem/27285714>

[Jiewen Tan]

Being imported to radar for better task management.

[Jiewen Tan]

Created attachment 285979 [details]
Patch

[Build Bot]

Comment on attachment 285979 [details]
Patch

Attachment 285979 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1860947

New failing tests:
js/dom/global-constructors-attributes-dedicated-worker.html

[Build Bot]

Created attachment 285986 [details]
Archive of layout-test-results from ews121 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[Jiewen Tan]

Created attachment 285989 [details]
Patch

[Darin Adler]

Comment on attachment 285989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285989&action=review

> Source/WebCore/page/Crypto.idl:32
> +    GenerateIsReachable=ImplScriptExecutionContext,
> +    Exposed=(Window,Worker),

Please keep these in alphabetical order.

> Source/WebCore/workers/WorkerGlobalScope.h:153
> +    Crypto* crypto() const;

Please change this to return a reference instead of a pointer.

> Source/WebCore/workers/WorkerGlobalScope.h:201
> +    mutable RefPtr<Crypto>  m_crypto;

Extra space here; please remove that.

[Jiewen Tan]

Comment on attachment 285989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285989&action=review

Thanks Darin for reviewing my patch.

>> Source/WebCore/page/Crypto.idl:32
>> +    Exposed=(Window,Worker),
> 
> Please keep these in alphabetical order.

Fixed.

>> Source/WebCore/workers/WorkerGlobalScope.h:153
>> +    Crypto* crypto() const;
> 
> Please change this to return a reference instead of a pointer.

Fixed.

>> Source/WebCore/workers/WorkerGlobalScope.h:201
>> +    mutable RefPtr<Crypto>  m_crypto;
> 
> Extra space here; please remove that.

Fixed.

[Jiewen Tan]

Created attachment 286073 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 286073 [details]
Patch for landing

Clearing flags on attachment: 286073

Committed r204481: <http://trac.webkit.org/changeset/204481>