Bug 104848 – sandboxed iframe attribute parsing layout tests are flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Klein]

The following layout test is flaky on most Chromium platforms:

fast/frames/sandboxed-iframe-attribute-parsing.html
fast/frames/sandboxed-iframe-parsing-space-characters.html

This does not seem to be a recent occurrence. See:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast/frames/sandboxed-iframe-attribute-parsing.html,fast/frames/sandboxed-iframe-parsing-space-characters.html

[Mike West]

I suspect this is the same issue we saw when adding detail to the multi-iframe CSP tests: the iframes load in an indeterminate order, meaning that the console messages are sometimes generated in a different order than expected.

We solved it for CSP by chaining the iframe loads; I'd like to not do that here, as it's quite slow. A different option would be to break these test into multiple tests, each with only a single iframe present. That makes things a bit more difficult to maintain, but would be consistent.

[Mike West]

Created attachment 180800 [details]
Patch

[Adam Barth]

Comment on attachment 180800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180800&action=review

Thanks.

> LayoutTests/fast/frames/resources/sandboxed-iframe-attribute-test.js:5
> +var frames = 0;         /* number of allowed frames that called back */

We usually use C++ style comments, but it doesn't really matter.

[WebKit Review Bot]

Comment on attachment 180800 [details]
Patch

Clearing flags on attachment: 180800

Committed r138625: <http://trac.webkit.org/changeset/138625>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.