Bug 104848 - sandboxed iframe attribute parsing layout tests are flaky
Summary: sandboxed iframe attribute parsing layout tests are flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-12 15:01 PST by Adam Klein
Modified: 2013-01-02 11:29 PST (History)
5 users (show)

See Also:


Attachments
Patch (39.17 KB, patch)
2012-12-27 07:33 PST, Mike West
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2012-12-12 15:01:03 PST
The following layout test is flaky on most Chromium platforms:

fast/frames/sandboxed-iframe-attribute-parsing.html
fast/frames/sandboxed-iframe-parsing-space-characters.html

This does not seem to be a recent occurrence. See:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast/frames/sandboxed-iframe-attribute-parsing.html,fast/frames/sandboxed-iframe-parsing-space-characters.html
Comment 1 Mike West 2012-12-27 06:48:57 PST
I suspect this is the same issue we saw when adding detail to the multi-iframe CSP tests: the iframes load in an indeterminate order, meaning that the console messages are sometimes generated in a different order than expected.

We solved it for CSP by chaining the iframe loads; I'd like to not do that here, as it's quite slow. A different option would be to break these test into multiple tests, each with only a single iframe present. That makes things a bit more difficult to maintain, but would be consistent.
Comment 2 Mike West 2012-12-27 07:33:14 PST
Created attachment 180800 [details]
Patch
Comment 3 Adam Barth 2013-01-02 11:22:38 PST
Comment on attachment 180800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180800&action=review

Thanks.

> LayoutTests/fast/frames/resources/sandboxed-iframe-attribute-test.js:5
> +var frames = 0;         /* number of allowed frames that called back */

We usually use C++ style comments, but it doesn't really matter.
Comment 4 WebKit Review Bot 2013-01-02 11:29:11 PST
Comment on attachment 180800 [details]
Patch

Clearing flags on attachment: 180800

Committed r138625: <http://trac.webkit.org/changeset/138625>
Comment 5 WebKit Review Bot 2013-01-02 11:29:14 PST
All reviewed patches have been landed.  Closing bug.