Currently the kFixedPointDenominator constant is set to either 64 or 1 depending on the SUBPIXEL_LAYOUT flag. As this constant is used to limit the range of supported values this results in inconsistencies across ports. By changing kFixedPointDenominator to always be 64 and introducing a new constant (kEffectiveFixedPointDenominator) that varies we can ensure that the same range of values are supported across ports regardless of the SUBPIXEL_LAYOUT flag.
Created attachment 179126 [details] Patch
Comment on attachment 179126 [details] Patch I'm fine with this from an EFL point of view.
CC'ing some more Gtk and Qt people as this will cause a tiny change on their port but it's a platform alignment so really an FYI.
Comment on attachment 179126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179126&action=review r=me, but let's give the port maintainer some time to comment if there is something we missed. > Source/WebCore/ChangeLog:22 > + Change to clamp and then round. As discussed, I would just not do this change as it's unrelated. Next time, please explain 'why' you did that instead of having me guess what was the intent.
Created attachment 179812 [details] Patch for landing
Comment on attachment 179812 [details] Patch for landing Clearing flags on attachment: 179812 Committed r138026: <http://trac.webkit.org/changeset/138026>
All reviewed patches have been landed. Closing bug.