Bug 104843 - Have kFixedPointDenominator be constant across ports
Summary: Have kFixedPointDenominator be constant across ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 104788
  Show dependency treegraph
 
Reported: 2012-12-12 14:17 PST by Emil A Eklund
Modified: 2012-12-18 08:46 PST (History)
20 users (show)

See Also:


Attachments
Patch (18.30 KB, patch)
2012-12-12 14:26 PST, Emil A Eklund
jchaffraix: review+
jchaffraix: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (16.69 KB, patch)
2012-12-17 15:21 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-12-12 14:17:27 PST
Currently the kFixedPointDenominator constant is set to either 64 or 1 depending on the SUBPIXEL_LAYOUT flag. As this constant is used to limit the range of supported values this results in inconsistencies across ports.

By changing kFixedPointDenominator to always be 64 and introducing a new constant (kEffectiveFixedPointDenominator) that varies we can ensure that the same range of values are supported across ports regardless of the SUBPIXEL_LAYOUT flag.
Comment 1 Emil A Eklund 2012-12-12 14:26:06 PST
Created attachment 179126 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-12-17 02:04:48 PST
Comment on attachment 179126 [details]
Patch

I'm fine with this from an EFL point of view.
Comment 3 Julien Chaffraix 2012-12-17 13:25:58 PST
CC'ing some more Gtk and Qt people as this will cause a tiny change on their port but it's a platform alignment so really an FYI.
Comment 4 Julien Chaffraix 2012-12-17 14:08:34 PST
Comment on attachment 179126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179126&action=review

r=me, but let's give the port maintainer some time to comment if there is something we missed.

> Source/WebCore/ChangeLog:22
> +        Change to clamp and then round.

As discussed, I would just not do this change as it's unrelated. Next time, please explain 'why' you did that instead of having me guess what was the intent.
Comment 5 Emil A Eklund 2012-12-17 15:21:07 PST
Created attachment 179812 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-12-18 08:46:09 PST
Comment on attachment 179812 [details]
Patch for landing

Clearing flags on attachment: 179812

Committed r138026: <http://trac.webkit.org/changeset/138026>
Comment 7 WebKit Review Bot 2012-12-18 08:46:17 PST
All reviewed patches have been landed.  Closing bug.