Bug 104840 - REGRESSION(137336): Generated run-ins are not placed correctly
Summary: REGRESSION(137336): Generated run-ins are not placed correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Sprehn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-12 14:04 PST by Elliott Sprehn
Modified: 2012-12-12 15:44 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.78 KB, patch)
2012-12-12 14:12 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Patch (7.01 KB, patch)
2012-12-12 14:20 PST, Elliott Sprehn 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Sprehn 2012-12-12 14:04:15 PST 
REGRESSION(137336): Generated run-ins are not placed correctly
Comment 1 Elliott Sprehn 2012-12-12 14:12:07 PST 
Created attachment 179122 [details]
Patch
Comment 2 Elliott Sprehn 2012-12-12 14:20:32 PST 
Created attachment 179125 [details]
Patch
Comment 3 Elliott Sprehn 2012-12-12 14:54:10 PST 
Comment on attachment 179125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179125&action=review

> Source/WebCore/rendering/RenderBlock.cpp:1836
> +    ASSERT(runIn->node());

Hmm, it seems this simplification is not possible because things like RenderButton::addChild create anonymous blocks with style()->display(). I had thought there was no way to create an anonymous run-in, but it appears I'm wrong.
Comment 4 Elliott Sprehn 2012-12-12 14:59:41 PST 
(In reply to comment #3)
> (From update of attachment 179125 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179125&action=review
> 
> > Source/WebCore/rendering/RenderBlock.cpp:1836
> > +    ASSERT(runIn->node());
> 
> Hmm, it seems this simplification is not possible because things like RenderButton::addChild create anonymous blocks with style()->display(). I had thought there was no way to create an anonymous run-in, but it appears I'm wrong.

Actually, after digging more it appears this can't happen so it should be fine to assert about this.
Comment 5 WebKit Review Bot 2012-12-12 15:44:20 PST 
Comment on attachment 179125 [details]
Patch

Clearing flags on attachment: 179125

Committed r137528: <http://trac.webkit.org/changeset/137528>
Comment 6 WebKit Review Bot 2012-12-12 15:44:24 PST 
All reviewed patches have been landed.  Closing bug.