Bug 104840 – REGRESSION(137336): Generated run-ins are not placed correctly

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Elliott Sprehn]

REGRESSION(137336): Generated run-ins are not placed correctly

[Elliott Sprehn]

Created attachment 179122 [details]
Patch

[Elliott Sprehn]

Created attachment 179125 [details]
Patch

[Elliott Sprehn]

Comment on attachment 179125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179125&action=review

> Source/WebCore/rendering/RenderBlock.cpp:1836
> +    ASSERT(runIn->node());

Hmm, it seems this simplification is not possible because things like RenderButton::addChild create anonymous blocks with style()->display(). I had thought there was no way to create an anonymous run-in, but it appears I'm wrong.

[Elliott Sprehn]

(In reply to comment #3)
> (From update of attachment 179125 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179125&action=review
> 
> > Source/WebCore/rendering/RenderBlock.cpp:1836
> > +    ASSERT(runIn->node());
> 
> Hmm, it seems this simplification is not possible because things like RenderButton::addChild create anonymous blocks with style()->display(). I had thought there was no way to create an anonymous run-in, but it appears I'm wrong.

Actually, after digging more it appears this can't happen so it should be fine to assert about this.

[WebKit Review Bot]

Comment on attachment 179125 [details]
Patch

Clearing flags on attachment: 179125

Committed r137528: <http://trac.webkit.org/changeset/137528>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.