Bug 104839 - build-webkit --chromium-android forces Make even when update-webkit used --ninja
Summary: build-webkit --chromium-android forces Make even when update-webkit used --ninja
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-12 13:47 PST by Eric Seidel (no email)
Modified: 2012-12-13 10:35 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2012-12-12 13:48 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-12-12 13:47:04 PST 
build-webkit --chromium-android forces Make even when update-webkit used --ninja
Comment 1 Eric Seidel (no email) 2012-12-12 13:48:23 PST 
Created attachment 179120 [details]
Patch
Comment 2 Nico Weber 2012-12-12 13:50:59 PST 
lgtm, but I'm not an reviewer.
Comment 3 Eric Seidel (no email) 2012-12-12 13:51:21 PST 
This is mostly just reverting http://trac.webkit.org/changeset/124219, and thus should be reviewed by Peter.
Comment 4 Nico Weber 2012-12-12 13:52:34 PST 
Peter lgtm'd this in https://bugs.webkit.org/show_bug.cgi?id=104434#c4
Comment 5 Eric Seidel (no email) 2012-12-12 13:54:59 PST 
(In reply to comment #4)
> Peter lgtm'd this in https://bugs.webkit.org/show_bug.cgi?id=104434#c4

Very true.  But I'd like to have him do it again. :)  Then he can be on the hook when his Android bots break. :)

I'll let him r+ and cq+ this while I sleep tonight :)
Comment 6 Tony Chang 2012-12-12 14:02:35 PST 
Comment on attachment 179120 [details]
Patch

Peter's not a reviewer.  I'll r+ and Peter can cq+ or cq- when he sees this.
Comment 7 Peter Beverloo 2012-12-13 10:17:52 PST 
Comment on attachment 179120 [details]
Patch

Thanks Eric! Verified that it starts using Ninja locally.
Comment 8 WebKit Review Bot 2012-12-13 10:35:54 PST 
Comment on attachment 179120 [details]
Patch

Clearing flags on attachment: 179120

Committed r137611: <http://trac.webkit.org/changeset/137611>
Comment 9 WebKit Review Bot 2012-12-13 10:35:58 PST 
All reviewed patches have been landed.  Closing bug.