Bug 104827 – [EFL] Build break with latest EFL libraries.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

After EFL 1.8,
EFL libraries depends on Eo, which is newly added EFL library, and some of structures in Evas, Ecore are refactored.

So, in order to build with EFL trunk,
We should add Eo dependency and change declarations of Evas, Evas_Object, Ecore_Timer when detected EFL 1.8 .

[Ryuan Choi]

Created attachment 179104 [details]
first draft

[Laszlo Gombos]

I think 1.8 support can be added as experimental to WebKit trunk if building on 1.8 is stable and does not cause a large number of regressions (some number of regressions are probably expected). This is a decision however that constantly needs to be monitored and reevaluated as EFL dependencies evolve.

Ryuan, do you have any sort of test results running the EFL WebKit port using EFL 1.8/trunk ? 

Having said that I think the recommended stable version for WebKit development needs to stay 1.7.x for quite some time.

[Ryuan Choi]

(In reply to comment #2)
> I think 1.8 support can be added as experimental to WebKit trunk if building on 1.8 is stable and does not cause a large number of regressions (some number of regressions are probably expected). This is a decision however that constantly needs to be monitored and reevaluated as EFL dependencies evolve.
>
> Ryuan, do you have any sort of test results running the EFL WebKit port using EFL 1.8/trunk ? 
>
I tested both WebKit1 and WebKit2 layout test on 1.7 and latest trunk(which we can say initial code of EFL 1.8) and got a same results.

It's because several EFL libraries are just refactored to Eo based classes and our rendering is depends on cairo.
 
> Having said that I think the recommended stable version for WebKit development needs to stay 1.7.x for quite some time.

Absolutely right, now this is just for building webkit/efl on latest EFL trunk.

I am not sure, I heard that first snapshot of 1.8 are planned in next march.
This will be usefull for EFL developers who install latest EFL code and want not to use jhbuild.

[Laszlo Gombos]

Comment on attachment 179104 [details]
first draft

View in context: https://bugs.webkit.org/attachment.cgi?id=179104&action=review

Make sense to me.

> Source/cmake/OptionsEfl.cmake:126
> +# Add Eo dependency if EFL version is equal to or greater 1.8
> +if (${EVAS_VERSION} VERSION_EQUAL 1.8 AND ${ECORE_VERSION} VERSION_EQUAL 1.8)

Comment does not seem to say what the code actually does. VERSION_EQUAL checks for "equal or greater" ?

[Ryuan Choi]

Created attachment 180339 [details]
Patch

[Ryuan Choi]

Created attachment 180436 [details]
patch for land

[WebKit Review Bot]

Comment on attachment 180436 [details]
patch for land

Clearing flags on attachment: 180436

Committed r138326: <http://trac.webkit.org/changeset/138326>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.