Bug 104823 - [BlackBerry] Clean up log output in WebKit/blackberry
Summary: [BlackBerry] Clean up log output in WebKit/blackberry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
URL:
Keywords:
: 105200 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-12-12 10:10 PST by Jakob Petsovits
Modified: 2012-12-17 12:14 PST (History)
9 users (show)

See Also:


Attachments
Patch (82.10 KB, patch)
2012-12-12 11:25 PST, Jakob Petsovits
no flags Details | Formatted Diff | Diff
Slightly better patch (83.74 KB, patch)
2012-12-12 11:33 PST, Jakob Petsovits
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2012-12-12 10:10:44 PST
Log output is a minor mess right now. The worst thing is that we use the BBLOG() macro for logs that are already covered by a preprocessor define, but there are also consistency issues with namespace usage and point/size/rect output formats, compiler warnings, unnecessary newlines, parameter indentation that would never pass stylebot checks, and even a build error for a debug block that's defined out and hasn't been updated to reflect current WebCore API.

It's getting on my nerves to have to adjust the logging code every time I enable it, and then keep it out of the resulting patches because it's not logically related. It's time to fix logging for good. Patch below.
Comment 1 Jakob Petsovits 2012-12-12 11:25:52 PST
Created attachment 179088 [details]
Patch
Comment 2 Jakob Petsovits 2012-12-12 11:28:22 PST
Comment on attachment 179088 [details]
Patch

Whoops, found two more missing Platform:: prefixes in Selection* and Input* log macros. Let's get these in too.
Comment 3 Jakob Petsovits 2012-12-12 11:33:03 PST
Created attachment 179089 [details]
Slightly better patch
Comment 4 WebKit Review Bot 2012-12-17 12:01:05 PST
Comment on attachment 179089 [details]
Slightly better patch

Clearing flags on attachment: 179089

Committed r137929: <http://trac.webkit.org/changeset/137929>
Comment 5 WebKit Review Bot 2012-12-17 12:01:09 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Nima Ghanavatian 2012-12-17 12:14:53 PST
*** Bug 105200 has been marked as a duplicate of this bug. ***