Log output is a minor mess right now. The worst thing is that we use the BBLOG() macro for logs that are already covered by a preprocessor define, but there are also consistency issues with namespace usage and point/size/rect output formats, compiler warnings, unnecessary newlines, parameter indentation that would never pass stylebot checks, and even a build error for a debug block that's defined out and hasn't been updated to reflect current WebCore API. It's getting on my nerves to have to adjust the logging code every time I enable it, and then keep it out of the resulting patches because it's not logically related. It's time to fix logging for good. Patch below.
Created attachment 179088 [details] Patch
Comment on attachment 179088 [details] Patch Whoops, found two more missing Platform:: prefixes in Selection* and Input* log macros. Let's get these in too.
Created attachment 179089 [details] Slightly better patch
Comment on attachment 179089 [details] Slightly better patch Clearing flags on attachment: 179089 Committed r137929: <http://trac.webkit.org/changeset/137929>
All reviewed patches have been landed. Closing bug.
*** Bug 105200 has been marked as a duplicate of this bug. ***