Bug 104820 - [chromium] Add destructor to WebPrerender
Summary: [chromium] Add destructor to WebPrerender
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Peters
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-12 09:16 PST by Gavin Peters
Modified: 2012-12-12 10:35 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.43 KB, patch)
2012-12-12 09:20 PST, Gavin Peters
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Peters 2012-12-12 09:16:57 PST
Add destructor to WebPrerender
Comment 1 Gavin Peters 2012-12-12 09:20:18 PST
Created attachment 179065 [details]
Patch
Comment 2 Gavin Peters 2012-12-12 09:23:47 PST
James,

This change should have been part of https://bugs.webkit.org/show_bug.cgi?id=96474 , but we missed it during review. It's causing me some trouble now in Chrome, which is catching the default constructor and having bad juju.

Adam's away this week, so I'd love it if you could look at this.

What do you think?
Comment 3 WebKit Review Bot 2012-12-12 09:23:51 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Gavin Peters 2012-12-12 09:53:21 PST
Comment on attachment 179065 [details]
Patch

Thanks, James!
Comment 5 WebKit Review Bot 2012-12-12 10:35:01 PST
Comment on attachment 179065 [details]
Patch

Clearing flags on attachment: 179065

Committed r137482: <http://trac.webkit.org/changeset/137482>
Comment 6 WebKit Review Bot 2012-12-12 10:35:05 PST
All reviewed patches have been landed.  Closing bug.