Bug 104819 - [GTK][AC][Clutter] The non-composited content is not painted
Summary: [GTK][AC][Clutter] The non-composited content is not painted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joone Hur
URL:
Keywords:
Depends on:
Blocks: 105699
  Show dependency treegraph
 
Reported: 2012-12-12 09:01 PST by Joone Hur
Modified: 2013-01-14 10:46 PST (History)
4 users (show)

See Also:


Attachments
Patch (10.76 KB, patch)
2012-12-12 09:51 PST, Joone Hur
no flags Details | Formatted Diff | Diff
Patch (10.76 KB, patch)
2012-12-12 10:27 PST, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joone Hur 2012-12-12 09:01:38 PST
When Accelerated Compositing is enabled, GraphicsLayers are only painted.
Comment 1 Joone Hur 2012-12-12 09:51:27 PST
Created attachment 179071 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2012-12-12 10:14:49 PST
Comment on attachment 179071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179071&action=review

> Source/WebKit/gtk/ChangeLog:8
> +        When Accelerated Compositing is enabled, GraphicsLayers are only painted.

"only GraphicsLayers are painted"

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:80
> -    WebCore::GraphicsLayer* m_rootGraphicsLayer;
>      GtkWidget* m_rootLayerEmbedder;
> +    OwnPtr<WebCore::GraphicsLayer> m_rootLayer;
> +    OwnPtr<WebCore::GraphicsLayer> m_nonCompositedContentLayer;

I'd like to take this m_rootLayer declaration out of the if/elifs if possible, since all implementations use this. But this can be done in another patch and we can grab feedback from mrobinson for that, too.
Comment 3 Joone Hur 2012-12-12 10:27:24 PST
Created attachment 179077 [details]
Patch
Comment 4 WebKit Review Bot 2012-12-12 10:45:29 PST
Comment on attachment 179077 [details]
Patch

Clearing flags on attachment: 179077

Committed r137483: <http://trac.webkit.org/changeset/137483>