Bug 104790 - REGRESSION (r137432): The /webkit2/WebKitCookieManager/accept-policy unit test is failing
: REGRESSION (r137432): The /webkit2/WebKitCookieManager/accept-policy unit tes...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
: Gtk, Regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-12 03:08 PST by Zan Dobersek
Modified: 2012-12-13 03:11 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.59 KB, patch)
2012-12-13 01:29 PST, Joaquim Rocha
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-12-12 03:08:13 PST
http://trac.webkit.org/changeset/137432

Here's the output:

TEST: ./Tools/gtk/../Scripts/../../WebKitBuild/Release/Programs/WebKit2APITests/TestCookieManager... (pid=20217)

  /webkit2/WebKitCookieManager/accept-policy:                          **

ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp:176:void testCookieManagerAcceptPolicy(CookieManagerTest*, gconstpointer): assertion failed (test->getAcceptPolicy() == WEBKIT_COOKIE_POLICY_ACCEPT_NO_THIRD_PARTY): (1 == 2)

FAIL
Comment 1 Joaquim Rocha 2012-12-12 03:11:05 PST
I will take a look.
Comment 2 Zan Dobersek 2012-12-12 03:13:39 PST
Skipped in r137445.
http://trac.webkit.org/changeset/137445
Comment 3 Joaquim Rocha 2012-12-13 01:29:36 PST
Created attachment 179229 [details]
Patch
Comment 4 Joaquim Rocha 2012-12-13 01:30:57 PST
Comment on attachment 179229 [details]
Patch

Add cq?
Comment 5 Carlos Garcia Campos 2012-12-13 01:33:44 PST
Comment on attachment 179229 [details]
Patch

Thanks!
Comment 6 WebKit Review Bot 2012-12-13 03:11:35 PST
Comment on attachment 179229 [details]
Patch

Clearing flags on attachment: 179229

Committed r137581: <http://trac.webkit.org/changeset/137581>
Comment 7 WebKit Review Bot 2012-12-13 03:11:38 PST
All reviewed patches have been landed.  Closing bug.