Bug 104783 - [chromium] WebTestPlugin must not depend on WTF::String
Summary: [chromium] WebTestPlugin must not depend on WTF::String
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-12 02:00 PST by jochen
Modified: 2012-12-12 02:38 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2012-12-12 02:08 PST, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-12-12 02:00:27 PST 
[chromium] WebTestPlugin must not depend on WTF::String
Comment 1 jochen 2012-12-12 02:08:01 PST 
Created attachment 179005 [details]
Patch
Comment 2 Kent Tamura 2012-12-12 02:13:11 PST 
Comment on attachment 179005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179005&action=review

> Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:108
> +        snprintf(buffer, sizeof(buffer), "* %d, %d: %s\n", points[i].position.x, points[i].position.y, pointState(points[i].state));

I'm not sure snprintf is available in Visual Studio.
Comment 3 jochen 2012-12-12 02:14:13 PST 
(In reply to comment #2)
> (From update of attachment 179005 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179005&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:108
> > +        snprintf(buffer, sizeof(buffer), "* %d, %d: %s\n", points[i].position.x, points[i].position.y, pointState(points[i].state));
> 
> I'm not sure snprintf is available in Visual Studio.

It is (also, it's used in other files in the TestRunner library already)
Comment 4 WebKit Review Bot 2012-12-12 02:38:31 PST 
Comment on attachment 179005 [details]
Patch

Clearing flags on attachment: 179005

Committed r137439: <http://trac.webkit.org/changeset/137439>
Comment 5 WebKit Review Bot 2012-12-12 02:38:34 PST 
All reviewed patches have been landed.  Closing bug.