Bug 104783 – [chromium] WebTestPlugin must not depend on WTF::String

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[chromium] WebTestPlugin must not depend on WTF::String

Created attachment 179005 [details]
Patch

[Kent Tamura]

Comment on attachment 179005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179005&action=review

> Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:108
> +        snprintf(buffer, sizeof(buffer), "* %d, %d: %s\n", points[i].position.x, points[i].position.y, pointState(points[i].state));

I'm not sure snprintf is available in Visual Studio.

(In reply to comment #2)
> (From update of attachment 179005 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179005&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:108
> > +        snprintf(buffer, sizeof(buffer), "* %d, %d: %s\n", points[i].position.x, points[i].position.y, pointState(points[i].state));
> 
> I'm not sure snprintf is available in Visual Studio.

It is (also, it's used in other files in the TestRunner library already)

[WebKit Review Bot]

Comment on attachment 179005 [details]
Patch

Clearing flags on attachment: 179005

Committed r137439: <http://trac.webkit.org/changeset/137439>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.