Bug 104781 - [Qt] Fix linkage against SQLite
Summary: [Qt] Fix linkage against SQLite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-12 01:48 PST by Simon Hausmann
Modified: 2012-12-12 04:58 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.50 KB, patch)
2012-12-12 01:50 PST, Simon Hausmann
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2012-12-12 01:48:08 PST
[Qt] Fix linkage against SQLite
Comment 1 Simon Hausmann 2012-12-12 01:50:38 PST
Created attachment 179002 [details]
Patch
Comment 2 Csaba Osztrogonác 2012-12-12 02:39:15 PST
Comment on attachment 179002 [details]
Patch

LGTM, r=me.
Comment 3 Simon Hausmann 2012-12-12 02:55:58 PST
Committed r137444: <http://trac.webkit.org/changeset/137444>
Comment 4 Csaba Osztrogonác 2012-12-12 03:16:54 PST
(In reply to comment #3)
> Committed r137444: <http://trac.webkit.org/changeset/137444>

It broke the Mac build:
------------------------
Project ERROR: WebKit requires SQLite. Either make it available via pkg-config, set $SQLITE3SRCDIR or build WebKit under qt5.git.

I have no idea why, and I can't debug it without Mac build environment.

and the ARM build:
-------------------
Failed to set up build environment using qmake!
Project ERROR: WebKit requires SQLite. Either make it available via pkg-config, set $SQLITE3SRCDIR or build WebKit under qt5.git.

Hmmm ... It is the non-pkg-config (default for cross compiling), 
non-qt5.git and system sqlite installed case.
Comment 5 Simon Hausmann 2012-12-12 03:31:34 PST
Mac fix landed in http://trac.webkit.org/changeset/137446 *crossing fingers*
Comment 6 Csaba Osztrogonác 2012-12-12 04:58:58 PST
(In reply to comment #5)
> Mac fix landed in http://trac.webkit.org/changeset/137446 *crossing fingers*

And a typo fixed in http://trac.webkit.org/changeset/137452