Bug 104777 – Web Inspector: Native Memory Instrumentation: simplify Sequences processing code.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

The old code uses a free template function with two template arguments and a traits struct.
The function uses two template arguments, the user type and iterator type.

I found that if I need an overload for a type then I should overload the free template function.
It forces me to explicitly specify iterator type for the second template argument.
First of all it requires too many letters.
The second, I need to copy&paste such overload for all types of iterators. HashMap::const_iterator, HashSet::const_iterator, etc.

Solution: the free function needs to be converted to the traits function.

Patch to follow.

[Ilya Tikhonovsky]

Created attachment 178996 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 178996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178996&action=review

> Source/WTF/ChangeLog:8
> +        Drive by fix: redesign reportMemoryUsage for the sequences.

Drive by?

> Source/WTF/wtf/MemoryInstrumentationSequence.h:39
> +template <typename T> struct IsNotConvertibleType {

IsNotConvertibleType -> NotConvertibleToInteger

[Ilya Tikhonovsky]

Committed r137435: <http://trac.webkit.org/changeset/137435>