Remove redundant semicolons in RenderStyle.h
Created attachment 178990 [details] Patch
Comment on attachment 178990 [details] Patch I don't think that this is an improvement. Statements should end with semicolons for consistency, otherwise the code looks wrong to humans. If you really want to avoid redundant semicolons, please change the macros to require them.
Yup. Generally we write our macros to require semicolons. :) Please don't remove these.
Thank you for your comments. Some lines ends with semicolons, others not. I think it's not consistent. How about to change all lines end with semicolons? Or no need to change?
I'd be happy to r+ such a change. But better than doing it manually would be to make sure check-webkit-style knows how to catch macro-lines w/o a ;, and to make sure that the WebKit style guide makes this explicit. W/o changing those patches to fix the code are only a temporary fix at best.
(In reply to comment #5) > I'd be happy to r+ such a change. But better than doing it manually would be to make sure check-webkit-style knows how to catch macro-lines w/o a ;, and to make sure that the WebKit style guide makes this explicit. W/o changing those patches to fix the code are only a temporary fix at best. I'll make a patch to add ; first. And then make another bug for what you said. Thanks.
Created attachment 179145 [details] Patch
Comment on attachment 179145 [details] Patch :shrug: I'm not sure this really helps. But I don't see it really hurting either.
Comment on attachment 179145 [details] Patch Clearing flags on attachment: 179145 Committed r137950: <http://trac.webkit.org/changeset/137950>
All reviewed patches have been landed. Closing bug.