Bug 10477 – Unix build failure due to using "String.h" instead of "PlatformString.h"

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Krzysztof Kowalczyk]

A recent checkin to DOMParser.cpp does #include "String.h"

I assume it was supposed to be #include "PlatfromString.h" because I can't see "String.h" anywhere in the sources and no other file (as far as I can tell) uses "Stringh"

Patch attached.

[Krzysztof Kowalczyk]

Created attachment 10114 [details]
#include "PlatfromString.h" instead of "String.h"

[Mark Rowe (bdash)]

Patches generally require ChangeLog entries.

[Krzysztof Kowalczyk]

I'll be happy to provide one but I was under the impression that ChangeLog entries are written by actual commiters. That's how it worked for all the patches I've submitted so far.

Does that meant that I also have to provide a diff against ChangeLog or should it be written in the bug?

I'm all for playing by the rules but for trivial patches like this one it seems like an overkill.

[Eric Seidel (no email)]

Comment on attachment 10114 [details]
#include "PlatfromString.h" instead of "String.h"

I believe Wildfox fixed this in another recent patch.  Either could land.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> I'll be happy to provide one but I was under the impression that ChangeLog
> entries are written by actual commiters. That's how it worked for all the
> patches I've submitted so far.
> 
> Does that meant that I also have to provide a diff against ChangeLog or should
> it be written in the bug?
> 
> I'm all for playing by the rules but for trivial patches like this one it seems
> like an overkill.

ChangeLog entries should be created for all bugs.  Although the web page doesn't talk about it (yet), the WebKitTools/Scripts/prepare-ChangeLog script will create one for you--you just have to fill in the details.

http://webkit.opendarwin.org/coding/contributing.html

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> (From update of attachment 10114 [details] [edit])
> I believe Wildfox fixed this in another recent patch.  Either could land.

This was fixed in the patch for Bug 10465 by r15932.


*** This bug has been marked as a duplicate of 10465 ***