Bug 104765 - Copying text with ruby inserts new lines around rt elements
Summary: Copying text with ruby inserts new lines around rt elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-12-11 22:01 PST by Ryosuke Niwa
Modified: 2012-12-12 09:54 PST (History)
9 users (show)

See Also:

Attachments
Patch (4.82 KB, patch)
2012-12-11 22:06 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch (7.29 KB, patch)
2012-12-11 22:21 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (13.03 KB, patch)
2012-12-12 01:42 PST, Ryosuke Niwa 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-12-11 22:01:02 PST 
Copying text with ruby inserts new lines around rt elements
Comment 1 Ryosuke Niwa 2012-12-11 22:06:12 PST 
Created attachment 178964 [details]
Patch
Comment 2 Ryosuke Niwa 2012-12-11 22:08:07 PST 
<rdar://problem/12715037>
Comment 3 Ryosuke Niwa 2012-12-11 22:21:13 PST 
Created attachment 178966 [details]
Patch
Comment 4 Ryosuke Niwa 2012-12-11 22:23:48 PST 
Comment on attachment 178966 [details]
Patch

Thanks for the review! I’m excited to fix this bug.
Comment 5 WebKit Review Bot 2012-12-11 23:16:08 PST 
Comment on attachment 178966 [details]
Patch

Rejecting attachment 178966 [details] from commit-queue.

New failing tests:
fast/ruby/after-doesnt-crash.html
fast/ruby/rubyDOM-insert-rt-block-1.html
fast/ruby/rubyDOM-remove-rt-block-3.html
fast/ruby/rubyDOM-remove-rt-block-2.html
fast/ruby/ruby-text-indent.html
fast/ruby/before-doesnt-crash.html
fast/ruby/ruby-line-height.html
fast/ruby/rubyDOM-insert-rt-block-3.html
fast/ruby/text-emphasis.html
fast/ruby/parse-rp.html
fast/ruby/rubyDOM-remove-rt-block-1.html
fast/block/line-layout/selection-highlight-crash.html
fast/ruby/rubyDOM-insert-rt-block-2.html
Full output: http://queues.webkit.org/results/15278445
Comment 6 Ryosuke Niwa 2012-12-11 23:34:27 PST 
Oh oops, I forgot that my patch also affects innerText & DRT results. Will rebaseline them before landing it.
Comment 7 WebKit Review Bot 2012-12-12 00:06:58 PST 
Comment on attachment 178966 [details]
Patch

Attachment 178966 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15272644

New failing tests:
fast/ruby/after-doesnt-crash.html
fast/ruby/rubyDOM-insert-rt-block-1.html
fast/ruby/rubyDOM-remove-rt-block-3.html
fast/ruby/rubyDOM-remove-rt-block-2.html
fast/ruby/ruby-text-indent.html
fast/ruby/before-doesnt-crash.html
fast/ruby/ruby-line-height.html
fast/ruby/rubyDOM-insert-rt-block-3.html
fast/ruby/text-emphasis.html
fast/ruby/parse-rp.html
fast/ruby/rubyDOM-remove-rt-block-1.html
fast/block/line-layout/selection-highlight-crash.html
fast/ruby/rubyDOM-insert-rt-block-2.html
Comment 8 Ryosuke Niwa 2012-12-12 01:42:33 PST 
Created attachment 178999 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-12-12 02:25:52 PST 
Comment on attachment 178999 [details]
Patch for landing

Attachment 178999 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15276604

New failing tests:
fast/block/line-layout/selection-highlight-crash.html
Comment 10 Ryosuke Niwa 2012-12-12 09:54:47 PST 
Committed r137477: <http://trac.webkit.org/changeset/137477>