Bug 104747 – [CSS Grid Layout] Implement CSS parsing and handling for min-content and max-content

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Julien Chaffraix]

We currently don't allow min-content and max-content to be a <track-breadth> which is allowed by the specification.

Per discussion with Ojan and Tony, we will use the prefixed version of min-content / max-content.

[Julien Chaffraix]

Created attachment 178936 [details]
Proposed parsing / style resolution extension.

[Alexis Menard (darktears)]

Comment on attachment 178936 [details]
Proposed parsing / style resolution extension.

View in context: https://bugs.webkit.org/attachment.cgi?id=178936&action=review

> LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js:141
> +element.style.webkitGridColumns = "minmax(-webkit-min-content, -webkit-max-content)";

You could also test the element.style return value in addition of the computed style. Just for the sake of it.

[Julien Chaffraix]

Comment on attachment 178936 [details]
Proposed parsing / style resolution extension.

View in context: https://bugs.webkit.org/attachment.cgi?id=178936&action=review

>> LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js:141
>> +element.style.webkitGridColumns = "minmax(-webkit-min-content, -webkit-max-content)";
> 
> You could also test the element.style return value in addition of the computed style. Just for the sake of it.

Very, very good catch. It seems that this is broken (as we have no coverage for that case). Per our discussion, I filed bug 104821 to track adding the coverage and fixing it.

[WebKit Review Bot]

Comment on attachment 178936 [details]
Proposed parsing / style resolution extension.

Clearing flags on attachment: 178936

Committed r137478: <http://trac.webkit.org/changeset/137478>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.