Bug 104716 - [BlackBerry] Shift the spell check dialog to align with text after transformation
Summary: [BlackBerry] Shift the spell check dialog to align with text after transforma...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-11 14:02 PST by Nima Ghanavatian
Modified: 2012-12-11 17:09 PST (History)
5 users (show)

See Also:

Attachments
Patch (15.52 KB, patch)
2012-12-11 14:07 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Patch (15.40 KB, patch)
2012-12-11 15:10 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Patch (15.26 KB, patch)
2012-12-11 15:55 PST, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2012-12-11 14:02:15 PST 
SSIA
Comment 1 Nima Ghanavatian 2012-12-11 14:07:44 PST 
Created attachment 178870 [details]
Patch
Comment 2 Rob Buis 2012-12-11 14:14:12 PST 
Comment on attachment 178870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178870&action=review

> Source/WebKit/blackberry/WebKitSupport/InputHandler.h:215
> +    bool didSpellCheckWord() { return m_didSpellCheckWord; }

This could be const.
Comment 3 Rob Buis 2012-12-11 14:20:50 PST 
Comment on attachment 178870 [details]
Patch

LGTM.
Comment 4 Nima Ghanavatian 2012-12-11 15:10:42 PST 
Created attachment 178888 [details]
Patch
Comment 5 Nima Ghanavatian 2012-12-11 15:55:01 PST 
Created attachment 178903 [details]
Patch
Comment 6 Nima Ghanavatian 2012-12-11 15:55:58 PST 
Repo wasn't rebased against upstream. This one should apply clean.
Comment 7 Rob Buis 2012-12-11 15:58:26 PST 
Comment on attachment 178903 [details]
Patch

LGTM.
Comment 8 WebKit Review Bot 2012-12-11 17:09:32 PST 
Comment on attachment 178903 [details]
Patch

Clearing flags on attachment: 178903

Committed r137392: <http://trac.webkit.org/changeset/137392>
Comment 9 WebKit Review Bot 2012-12-11 17:09:36 PST 
All reviewed patches have been landed.  Closing bug.