RESOLVED FIXED 104716
[BlackBerry] Shift the spell check dialog to align with text after transformation 
https://bugs.webkit.org/show_bug.cgi?id=104716
Summary [BlackBerry] Shift the spell check dialog to align with text after transforma...
Nima Ghanavatian
Reported 2012-12-11 14:02:15 PST
SSIA
Attachments
Patch (15.52 KB, patch)
2012-12-11 14:07 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (15.40 KB, patch)
2012-12-11 15:10 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (15.26 KB, patch)
2012-12-11 15:55 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2012-12-11 14:07:44 PST
Created attachment 178870 [details] Patch
Rob Buis
Comment 2 2012-12-11 14:14:12 PST
Comment on attachment 178870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178870&action=review > Source/WebKit/blackberry/WebKitSupport/InputHandler.h:215 > + bool didSpellCheckWord() { return m_didSpellCheckWord; } This could be const.
Rob Buis
Comment 3 2012-12-11 14:20:50 PST
Comment on attachment 178870 [details] Patch LGTM.
Nima Ghanavatian
Comment 4 2012-12-11 15:10:42 PST
Created attachment 178888 [details] Patch
Nima Ghanavatian
Comment 5 2012-12-11 15:55:01 PST
Created attachment 178903 [details] Patch
Nima Ghanavatian
Comment 6 2012-12-11 15:55:58 PST
Repo wasn't rebased against upstream. This one should apply clean.
Rob Buis
Comment 7 2012-12-11 15:58:26 PST
Comment on attachment 178903 [details] Patch LGTM.
WebKit Review Bot
Comment 8 2012-12-11 17:09:32 PST
Comment on attachment 178903 [details] Patch Clearing flags on attachment: 178903 Committed r137392: <http://trac.webkit.org/changeset/137392>
WebKit Review Bot
Comment 9 2012-12-11 17:09:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.