Bug 104714 - Add window.internals.mainThreadScrollReasonsAsText for testing slow scrolling
Summary: Add window.internals.mainThreadScrollReasonsAsText for testing slow scrolling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on:
Blocks: 102543
  Show dependency tree / graph
 
Reported: 2012-12-11 13:43 PST by Xianzhu Wang
Modified: 2012-12-12 10:54 PST (History)
7 users (show)

See Also:

Attachments
Patch (13.75 KB, patch)
2012-12-11 13:51 PST, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
Patch (13.78 KB, patch)
2012-12-11 14:18 PST, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-12-11 13:43:46 PST 
Bug 102543 is about slow scrolling caused by out-of-view fixed position elements. It needs a way to test if slow scrolling is triggered.
This bug is to separate the patch to bug 102543 into smaller parts.
Comment 1 Xianzhu Wang 2012-12-11 13:51:16 PST 
Created attachment 178867 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-12-11 14:06:58 PST 
Comment on attachment 178867 [details]
Patch

LGTM.
Comment 3 Eric Seidel (no email) 2012-12-11 14:07:17 PST 
Thank you for breaking this out, this should make your main patch even smaller and easier to understand.
Comment 4 WebKit Review Bot 2012-12-11 14:10:27 PST 
Comment on attachment 178867 [details]
Patch

Rejecting attachment 178867 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

/mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15259689
Comment 5 Xianzhu Wang 2012-12-11 14:18:13 PST 
Created attachment 178873 [details]
Patch
Comment 6 WebKit Review Bot 2012-12-11 16:57:44 PST 
Comment on attachment 178873 [details]
Patch

Clearing flags on attachment: 178873

Committed r137388: <http://trac.webkit.org/changeset/137388>
Comment 7 WebKit Review Bot 2012-12-11 16:57:48 PST 
All reviewed patches have been landed.  Closing bug.