Bug 104707 - [Texmap] Remove lowp/highp indicators as they're not needed with ANGLE.
Summary: [Texmap] Remove lowp/highp indicators as they're not needed with ANGLE.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-11 13:06 PST by Noam Rosenthal
Modified: 2012-12-12 17:33 PST (History)
4 users (show)

See Also:


Attachments
Patch (15.82 KB, patch)
2012-12-11 13:08 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (15.86 KB, patch)
2012-12-12 00:23 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (15.86 KB, patch)
2012-12-12 12:21 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-12-11 13:06:51 PST
[Texmap] Remove lowp/highp indicators as they're not needed with ANGLE.
Comment 1 Noam Rosenthal 2012-12-11 13:08:13 PST
Created attachment 178859 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-11 21:47:04 PST
Comment on attachment 178859 [details]
Patch

Rejecting attachment 178859 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ed at 382 (offset 17 lines).
Hunk #17 succeeded at 395 (offset 17 lines).
Hunk #18 succeeded at 427 (offset 17 lines).
Hunk #19 succeeded at 461 (offset 17 lines).
Hunk #20 succeeded at 485 (offset 17 lines).
3 out of 20 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Martin Rob..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15285146
Comment 3 Noam Rosenthal 2012-12-12 00:23:10 PST
Created attachment 178987 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-12-12 00:35:53 PST
Comment on attachment 178987 [details]
Patch for landing

Rejecting attachment 178987 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

/mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15281404
Comment 5 Noam Rosenthal 2012-12-12 12:21:48 PST
Created attachment 179101 [details]
Patch
Comment 6 Kenneth Rohde Christiansen 2012-12-12 12:25:29 PST
Comment on attachment 179101 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179101&action=review

> Source/WebCore/ChangeLog:8
> +
> +        lowp/highp indicator were needed for GLES2, but ANGLE does not require them.

What is the harm? I mean can you explain this better?
Comment 7 Noam Rosenthal 2012-12-12 12:30:37 PST
(In reply to comment #6)
> (From update of attachment 179101 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179101&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +
> > +        lowp/highp indicator were needed for GLES2, but ANGLE does not require them.
> 
> What is the harm? I mean can you explain this better?
It's code with very little benefit if any, that makes the shaders harder to read.
Comment 8 WebKit Review Bot 2012-12-12 17:33:18 PST
Comment on attachment 179101 [details]
Patch

Clearing flags on attachment: 179101

Committed r137545: <http://trac.webkit.org/changeset/137545>
Comment 9 WebKit Review Bot 2012-12-12 17:33:22 PST
All reviewed patches have been landed.  Closing bug.