WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104706
Enable video track on Windows.
https://bugs.webkit.org/show_bug.cgi?id=104706
Summary
Enable video track on Windows.
Roger Fong
Reported
2012-12-11 12:56:38 PST
Set the ENABLE_VIDEO_TRACK and update the VS projects. Code changes to make things compile in debug mode properly.
Attachments
patch
(21.59 KB, patch)
2012-12-11 16:36 PST
,
Roger Fong
thorton
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Roger Fong
Comment 1
2012-12-11 13:13:33 PST
(In reply to
comment #0
)
> Set the ENABLE_VIDEO_TRACK and update the VS projects. > Code changes to make things compile in debug mode properly.
Just set the ENABLE_VIDEO_TRACK and update the VS projects.
Roger Fong
Comment 2
2012-12-11 16:36:06 PST
Created
attachment 178914
[details]
patch
Tim Horton
Comment 3
2012-12-11 16:38:46 PST
Comment on
attachment 178914
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=178914&action=review
> Source/WebCore/WebCore.vcproj/WebCore.vcproj:76700 > - RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js" > + RelativePath="..\inspector\front-end\JavaScriptFormatter.js" > > > </File> > <File > - RelativePath="..\inspector\front-end\JavaScriptFormatter.js" > + RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js"
Whaa?
Roger Fong
Comment 4
2012-12-11 16:40:59 PST
(In reply to
comment #3
)
> (From update of
attachment 178914
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=178914&action=review
> > > Source/WebCore/WebCore.vcproj/WebCore.vcproj:76700 > > - RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js" > > + RelativePath="..\inspector\front-end\JavaScriptFormatter.js" > > > > > </File> > > <File > > - RelativePath="..\inspector\front-end\JavaScriptFormatter.js" > > + RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js" > > Whaa?
o.0 No idea...I'll revert that part and make sure it all still works
Build Bot
Comment 5
2012-12-11 17:28:48 PST
Comment on
attachment 178914
[details]
patch
Attachment 178914
[details]
did not pass win-ews (win): Output:
http://queues.webkit.org/results/15285065
Csaba Osztrogonác
Comment 6
2012-12-12 11:47:19 PST
I assume this change was accidentally -
http://trac.webkit.org/changeset/137491/trunk/Source/WebCore/platform/NotImplemented.cpp#file0
Could you revert this change, please?
Roger Fong
Comment 7
2012-12-12 12:41:52 PST
(In reply to
comment #6
)
> I assume this change was accidentally -
http://trac.webkit.org/changeset/137491/trunk/Source/WebCore/platform/NotImplemented.cpp#file0
> > Could you revert this change, please?
Yeah sorry, rolled it out here:
http://trac.webkit.org/changeset/137497
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug