Bug 104706 - Enable video track on Windows.
Summary: Enable video track on Windows.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 104828
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-11 12:56 PST by Roger Fong
Modified: 2012-12-14 14:19 PST (History)
6 users (show)

See Also:

Attachments
patch (21.59 KB, patch)
2012-12-11 16:36 PST, Roger Fong 		thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2012-12-11 12:56:38 PST 
Set the ENABLE_VIDEO_TRACK and update the VS projects.
Code changes to make things compile in debug mode properly.
Comment 1 Roger Fong 2012-12-11 13:13:33 PST 
(In reply to comment #0)
> Set the ENABLE_VIDEO_TRACK and update the VS projects.
> Code changes to make things compile in debug mode properly.

Just set the ENABLE_VIDEO_TRACK and update the VS projects.
Comment 2 Roger Fong 2012-12-11 16:36:06 PST 
Created attachment 178914 [details]
patch
Comment 3 Tim Horton 2012-12-11 16:38:46 PST 
Comment on attachment 178914 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178914&action=review

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:76700
> -					RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js"
> +					RelativePath="..\inspector\front-end\JavaScriptFormatter.js"
>  					>
>  				</File>
>  				<File
> -					RelativePath="..\inspector\front-end\JavaScriptFormatter.js"
> +					RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js"

Whaa?
Comment 4 Roger Fong 2012-12-11 16:40:59 PST 
(In reply to comment #3)
> (From update of attachment 178914 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178914&action=review
> 
> > Source/WebCore/WebCore.vcproj/WebCore.vcproj:76700
> > -					RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js"
> > +					RelativePath="..\inspector\front-end\JavaScriptFormatter.js"
> >  					>
> >  				</File>
> >  				<File
> > -					RelativePath="..\inspector\front-end\JavaScriptFormatter.js"
> > +					RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js"
> 
> Whaa?

o.0 No idea...I'll revert that part and make sure it all still works
Comment 5 Build Bot 2012-12-11 17:28:48 PST 
Comment on attachment 178914 [details]
patch

Attachment 178914 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15285065
Comment 6 Csaba Osztrogonác 2012-12-12 11:47:19 PST 
I assume this change was accidentally - http://trac.webkit.org/changeset/137491/trunk/Source/WebCore/platform/NotImplemented.cpp#file0

Could you revert this change, please?
Comment 7 Roger Fong 2012-12-12 12:41:52 PST 
(In reply to comment #6)
> I assume this change was accidentally - http://trac.webkit.org/changeset/137491/trunk/Source/WebCore/platform/NotImplemented.cpp#file0
> 
> Could you revert this change, please?

Yeah sorry, rolled it out here: 
http://trac.webkit.org/changeset/137497