WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
104697
[chromium] Templated conversion from WebVector to Vector
https://bugs.webkit.org/show_bug.cgi?id=104697
Summary
[chromium] Templated conversion from WebVector to Vector
Alec Flett
Reported
2012-12-11 11:54:40 PST
Right now it's fairly tedious to manually convert a WebVector<T> to a Vector<U> darin suggests: --- Perhaps: template <typename C> copyTo(C* other); (^^^ Maybe the out param should be a reference instead to match WebKit style.) ---
Attachments
Patch
(3.54 KB, patch)
2012-12-11 16:02 PST
,
Alec Flett
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alec Flett
Comment 1
2012-12-11 16:02:22 PST
Created
attachment 178906
[details]
Patch
Alec Flett
Comment 2
2012-12-11 16:03:35 PST
Here's a strawman per darin's suggestion. The reference made usage a little cleaner since WTF::Vector and std::vector are rarely passed around as pointers.
Alec Flett
Comment 3
2013-02-27 13:27:29 PST
Ended up dealing with this more efficiently with WebData / SharedBuffer
Eric Seidel (no email)
Comment 4
2013-03-01 02:48:29 PST
Comment on
attachment 178906
[details]
Patch Cleared review? from
attachment 178906
[details]
so that this bug does not appear in
http://webkit.org/pending-review
. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug