Bug 104691 – [WK2 NetworkProcess] DOM cookie access functions should respect private browsing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alexey Proskuryakov]

DOM cookie access functions should respect private browsing.

<rdar://problem/12838354>

[Alexey Proskuryakov]

Created attachment 178841 [details]
proposed patch

[WebKit Review Bot]

Attachment 178841 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:160:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 178841 [details]
proposed patch

Attachment 178841 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15276326

[Sam Weinig]

Created attachment 178926 [details]
Patch

[WebKit Review Bot]

Attachment 178926 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:160:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 178926 [details]
Patch

Attachment 178926 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15282266

[Sam Weinig]

Created attachment 178941 [details]
Patch

[WebKit Review Bot]

Attachment 178941 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:160:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 178941 [details]
Patch

Attachment 178941 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15285236

[Alexey Proskuryakov]

Created attachment 179312 [details]
proposed patch

Sam's patch didn't include WebCore and WebKit1 changes.

[WebKit Review Bot]

Attachment 179312 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:159:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 179312 [details]
proposed patch

Attachment 179312 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15309381

[Alexey Proskuryakov]

Created attachment 179319 [details]
proposed patch

> 'WebCore/NotImplemnted.h': No such file or directory

Indeed.

[WebKit Review Bot]

Attachment 179319 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp:159:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 179319 [details]
proposed patch

Attachment 179319 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15319352

[Alexey Proskuryakov]

Oooh!!! So WebKit1 and WebKit2 on Windows share WebFrameNetworkingContext - the headers are separate, but since name and namespace are the same, and we have a single DLL, we are pulling the same implementation. Nonsense.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/137647>.

[Alexey Proskuryakov]

Oops, the patch was incomplete!

[Alexey Proskuryakov]

Created attachment 179337 [details]
follow-up

[Alexey Proskuryakov]

Follow-up committed <http://trac.webkit.org/changeset/137657>.