Bug 104679 - Web inspector prints a warning about "Debug" not being localized
: Web inspector prints a warning about "Debug" not being localized
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Martin Robinson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-11 09:20 PST by Martin Robinson
Modified: 2012-12-12 00:18 PST (History)
11 users (show)

See Also:


Attachments
Patch (1.55 KB, patch)
2012-12-11 09:25 PST, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-12-11 09:20:38 PST
In the stderr output for the GTK+ tests we are getting a lot of spurious output about "Debug" not being a localized string. For instance see: 

http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r137316%20(32039)/inspector/debugger/scripts-panel-stderr.txt
Comment 1 Martin Robinson 2012-12-11 09:25:28 PST
Created attachment 178819 [details]
Patch
Comment 2 kov's GTK+ EWS bot 2012-12-11 09:39:39 PST
Comment on attachment 178819 [details]
Patch

Attachment 178819 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15260479
Comment 3 Build Bot 2012-12-11 11:00:21 PST
Comment on attachment 178819 [details]
Patch

Attachment 178819 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15242919

New failing tests:
fast/frames/sandboxed-iframe-attribute-parsing.html
svg/as-image/img-preserveAspectRatio-support-2.html
Comment 4 Martin Robinson 2012-12-11 15:23:48 PST
I'm not sure if the GTK+ failure really relates to this patch, but I'll investigate further. I don't know how this could cause the tests listed to fail on Mac either. All I did was add a new localized string. Did you have a comment to attach to your r-?
Comment 5 Vsevolod Vlasov 2012-12-12 00:10:59 PST
(In reply to comment #4)
> I'm not sure if the GTK+ failure really relates to this patch, but I'll investigate further. I don't know how this could cause the tests listed to fail on Mac either. All I did was add a new localized string. Did you have a comment to attach to your r-?

I'm pretty sure Pavel meant to r+ this. :)
Comment 6 WebKit Review Bot 2012-12-12 00:18:36 PST
Comment on attachment 178819 [details]
Patch

Clearing flags on attachment: 178819

Committed r137430: <http://trac.webkit.org/changeset/137430>
Comment 7 WebKit Review Bot 2012-12-12 00:18:40 PST
All reviewed patches have been landed.  Closing bug.