Bug 104679 – Web inspector prints a warning about "Debug" not being localized

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Martin Robinson]

In the stderr output for the GTK+ tests we are getting a lot of spurious output about "Debug" not being a localized string. For instance see: 

http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r137316%20(32039)/inspector/debugger/scripts-panel-stderr.txt

[Martin Robinson]

Created attachment 178819 [details]
Patch

[kov's GTK+ EWS bot]

Comment on attachment 178819 [details]
Patch

Attachment 178819 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15260479

[Build Bot]

Comment on attachment 178819 [details]
Patch

Attachment 178819 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15242919

New failing tests:
fast/frames/sandboxed-iframe-attribute-parsing.html
svg/as-image/img-preserveAspectRatio-support-2.html

[Martin Robinson]

I'm not sure if the GTK+ failure really relates to this patch, but I'll investigate further. I don't know how this could cause the tests listed to fail on Mac either. All I did was add a new localized string. Did you have a comment to attach to your r-?

[Vsevolod Vlasov]

(In reply to comment #4)
> I'm not sure if the GTK+ failure really relates to this patch, but I'll investigate further. I don't know how this could cause the tests listed to fail on Mac either. All I did was add a new localized string. Did you have a comment to attach to your r-?

I'm pretty sure Pavel meant to r+ this. :)

[WebKit Review Bot]

Comment on attachment 178819 [details]
Patch

Clearing flags on attachment: 178819

Committed r137430: <http://trac.webkit.org/changeset/137430>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.