Bug 104670 – [GTK][AC] GraphicsLayers are not shown on the viewport

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Joone Hur]

GraphicsLayers are not shown on the viewport because we don't resize and show the GtkClutterEmbed yet.

[Joone Hur]

Created attachment 178922 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 178922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178922&action=review

LGTM, except for the duplicate timer scheduling.

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:59
> -    return false;
> +    return true;

This is what we need to implement to render the page contents, right?

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:93
> +    scheduleLayerFlush();
> +    m_layerFlushTimerCallbackId = g_timeout_add_full(GDK_PRIORITY_EVENTS, 0, reinterpret_cast<GSourceFunc>(layerFlushTimerFiredCallback), this, 0);

You're scheduling the flush twice here, gotta remove the g_timeout_add_full call.

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:132
> -    return FALSE;
> +    return false;

this returns a gboolean, so I'd keep FALSE here

[Joone Hur]

Comment on attachment 178922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178922&action=review

>> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:59
>> +    return true;
> 
> This is what we need to implement to render the page contents, right?

Yes, it seems to paint the main content on the root layer.

>> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:93
>> +    m_layerFlushTimerCallbackId = g_timeout_add_full(GDK_PRIORITY_EVENTS, 0, reinterpret_cast<GSourceFunc>(layerFlushTimerFiredCallback), this, 0);
> 
> You're scheduling the flush twice here, gotta remove the g_timeout_add_full call.

Yes, I will remove it.

>> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:132
>> +    return false;
> 
> this returns a gboolean, so I'd keep FALSE here

Ok.

[Joone Hur]

Created attachment 179012 [details]
Patch

[WebKit Review Bot]

Comment on attachment 179012 [details]
Patch

Clearing flags on attachment: 179012

Committed r137447: <http://trac.webkit.org/changeset/137447>

[Gustavo Noronha (kov)]

Comment on attachment 178922 [details]
Patch

Clearing flag for committed patch.