Bug 104668 - [GTK] Soup network logs are frequently interrupted by other logging messages
Summary: [GTK] Soup network logs are frequently interrupted by other logging messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-11 06:38 PST by Jonathon Jongsma (jonner)
Modified: 2012-12-11 10:59 PST (History)
5 users (show)

See Also:

Attachments
add custom soup log printer (2.16 KB, patch)
2012-12-11 06:53 PST, Jonathon Jongsma (jonner) 		no flags Details | Formatted Diff | Diff
fix nits (2.14 KB, patch)
2012-12-11 09:16 PST, Jonathon Jongsma (jonner) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathon Jongsma (jonner) 2012-12-11 06:38:32 PST 
The libsoup network logging should use the webkit logging infrastructure to print out network logging messages so that messages from all logging channels can be properly synchronized.
Comment 1 Jonathon Jongsma (jonner) 2012-12-11 06:53:31 PST 
Created attachment 178793 [details]
add custom soup log printer
Comment 2 Martin Robinson 2012-12-11 07:12:07 PST 
Comment on attachment 178793 [details]
add custom soup log printer

View in context: https://bugs.webkit.org/attachment.cgi?id=178793&action=review

Thanks!

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:81
> +inline static void soupLogPrinter(SoupLogger *logger, SoupLoggerLogLevel level, char direction, const char* data, gpointer userData)

Nit: SoupLogger *logger should be SoupLogger* logger and you can omit the "userData" and "level" here entirely.
Comment 3 Jonathon Jongsma (jonner) 2012-12-11 09:16:41 PST 
Created attachment 178818 [details]
fix nits
Comment 4 WebKit Review Bot 2012-12-11 10:59:20 PST 
Comment on attachment 178818 [details]
fix nits

Clearing flags on attachment: 178818

Committed r137337: <http://trac.webkit.org/changeset/137337>
Comment 5 WebKit Review Bot 2012-12-11 10:59:23 PST 
All reviewed patches have been landed.  Closing bug.