It would be nice to have Qt support in WebKit :-)
Created attachment 10104 [details] Initial patch This patch contains all the PLATFORM(QT) hooks.
Comment on attachment 10104 [details] Initial patch This would probably be better as if !PLATFORM(QT) +#if PLATFORM(QT) + // use default QCursor constructor. QCursor(0) creates + // an invalid cursor due to implicit constructors ;( +#else + : m_impl(0) +#endif + { } Would be nice to fix the funny spacing while we're there: +#if PLATFORM(GDK) || PLATFORM(QT) ResourceLoaderInternal * getInternal() { return d;} #endif No need to name the argument "parent" here, it's implied by the method: +#if PLATFORM(QT) + virtual void setParentWidget(QWidget* parent); +#endif Same here: +#if PLATFORM(QT) + QWidget* parentWidget() const; + virtual void setParentWidget(QWidget* parent); + + QWidget* qwidget(); + void setQWidget(QWidget* widget); +#endif named arguments in headers often tend to just clutter things. and another: + + virtual void setParentWidget(QWidget* parent); + This is a really nice patch though. r=me
Comment on attachment 10104 [details] Initial patch Hum... Since some of these changes are bigger than 5 lines (what amounts to a "trivial change") they really need copyright updates at the top.
Created attachment 10118 [details] Corrected patch Incorporated Eric's comments.
Comment on attachment 10118 [details] Corrected patch Fabulous. r=me.
Landed by rwlbuis in r15933 and r15935.