Bug 10466 - WebKit should have Qt platform support
Summary: WebKit should have Qt platform support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: Other OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-17 12:55 PDT by Nikolas Zimmermann
Modified: 2006-08-18 06:53 PDT (History)
0 users

See Also:


Attachments
Initial patch (14.04 KB, patch)
2006-08-17 12:58 PDT, Nikolas Zimmermann
eric: review+
Details | Formatted Diff | Diff
Corrected patch (13.96 KB, patch)
2006-08-18 02:21 PDT, Nikolas Zimmermann
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2006-08-17 12:55:05 PDT
It would be nice to have Qt support in WebKit :-)
Comment 1 Nikolas Zimmermann 2006-08-17 12:58:14 PDT
Created attachment 10104 [details]
Initial patch

This patch contains all the PLATFORM(QT) hooks.
Comment 2 Eric Seidel 2006-08-18 01:41:54 PDT
Comment on attachment 10104 [details]
Initial patch

This would probably be better as if !PLATFORM(QT)

+#if PLATFORM(QT)
+        // use default QCursor constructor. QCursor(0) creates
+        // an invalid cursor due to implicit constructors ;(
+#else
+        : m_impl(0)
+#endif
+		{ }

Would be nice to fix the funny spacing while we're there:

+#if PLATFORM(GDK) || PLATFORM(QT)
     ResourceLoaderInternal * getInternal() { return d;}
 #endif

No need to name the argument "parent" here, it's implied by the method:

+#if PLATFORM(QT)
+    virtual void setParentWidget(QWidget* parent);
+#endif


Same here:

+#if PLATFORM(QT)
+        QWidget* parentWidget() const;
+        virtual void setParentWidget(QWidget* parent);
+
+        QWidget* qwidget();
+        void setQWidget(QWidget* widget);
+#endif

named arguments in headers often tend to just clutter things.

and another:

+
+        virtual void setParentWidget(QWidget* parent);
+

This is a really nice patch though.

r=me
Comment 3 Eric Seidel 2006-08-18 01:43:17 PDT
Comment on attachment 10104 [details]
Initial patch

Hum... Since some of these changes are bigger than 5 lines (what amounts to a "trivial change") they really need copyright updates at the top.
Comment 4 Nikolas Zimmermann 2006-08-18 02:21:15 PDT
Created attachment 10118 [details]
Corrected patch

Incorporated Eric's comments.
Comment 5 Eric Seidel 2006-08-18 02:32:59 PDT
Comment on attachment 10118 [details]
Corrected patch

Fabulous.  r=me.
Comment 6 David Kilzer (:ddkilzer) 2006-08-18 06:53:44 PDT
Landed by rwlbuis in r15933 and r15935.