RESOLVED FIXED 104642
NetworkInfoController needs to support destructor 
https://bugs.webkit.org/show_bug.cgi?id=104642
Summary NetworkInfoController needs to support destructor
Gyuyoung Kim
Reported 2012-12-10 23:56:39 PST
Though NetworkInfoController can be created by each port, there is no virtual interface to destroy it. Because, each port needs to use the NetworkInfoController to update network status change as battery status.
Attachments
Proposed Patch (10.46 KB, patch)
2012-12-11 00:17 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (11.70 KB, patch)
2012-12-11 17:31 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-12-11 00:17:59 PST
Created attachment 178737 [details] Proposed Patch
Gyuyoung Kim
Comment 2 2012-12-11 17:31:29 PST
Created attachment 178930 [details] Patch
Gyuyoung Kim
Comment 3 2012-12-11 17:33:16 PST
CC'ing Morrita and Kentaro, could you take a look ? Rob and Mike, could you check if there is no problem in blackberry port ?
Kentaro Hara
Comment 4 2012-12-11 18:02:39 PST
Looks good to me. morrita-san: could you take another look?
Yong Li
Comment 5 2012-12-12 07:32:58 PST
(In reply to comment #3) > CC'ing Morrita and Kentaro, could you take a look ? > > Rob and Mike, could you check if there is no problem in blackberry port ? Seems it fixes a leak for bb port. Thanks for the patch
Hajime Morrita
Comment 6 2012-12-12 15:52:50 PST
rs=me base on Yong's comment.
Gyuyoung Kim
Comment 7 2012-12-12 19:59:08 PST
(In reply to comment #6) > rs=me base on Yong's comment. Thank you for your rs. But, when ?
Kentaro Hara
Comment 8 2012-12-12 20:03:10 PST
Comment on attachment 178930 [details] Patch It looks like morrita isn't around now. rs=me.
Hajime Morrita
Comment 9 2012-12-12 20:44:39 PST
(In reply to comment #8) > (From update of attachment 178930 [details]) > It looks like morrita isn't around now. rs=me. Oops sorry. I thought I did this but actually didn't.
WebKit Review Bot
Comment 10 2012-12-12 21:52:45 PST
Comment on attachment 178930 [details] Patch Clearing flags on attachment: 178930 Committed r137568: <http://trac.webkit.org/changeset/137568>
WebKit Review Bot
Comment 11 2012-12-12 21:52:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.