Bug 104642 - NetworkInfoController needs to support destructor
Summary: NetworkInfoController needs to support destructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 104465
  Show dependency tree / graph
 
Reported: 2012-12-10 23:56 PST by Gyuyoung Kim
Modified: 2012-12-12 21:52 PST (History)
8 users (show)

See Also:

Attachments
Proposed Patch (10.46 KB, patch)
2012-12-11 00:17 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (11.70 KB, patch)
2012-12-11 17:31 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-12-10 23:56:39 PST 
Though NetworkInfoController can be created by each port, there is no virtual interface to destroy it. Because, each port needs to use the NetworkInfoController to update network status change as battery status.
Comment 1 Gyuyoung Kim 2012-12-11 00:17:59 PST 
Created attachment 178737 [details]
Proposed Patch
Comment 2 Gyuyoung Kim 2012-12-11 17:31:29 PST 
Created attachment 178930 [details]
Patch
Comment 3 Gyuyoung Kim 2012-12-11 17:33:16 PST 
CC'ing Morrita and Kentaro, could you take a look ? 

Rob and Mike, could you check if there is no problem in blackberry port ?
Comment 4 Kentaro Hara 2012-12-11 18:02:39 PST 
Looks good to me. morrita-san: could you take another look?
Comment 5 Yong Li 2012-12-12 07:32:58 PST 
(In reply to comment #3)
> CC'ing Morrita and Kentaro, could you take a look ? 
> 
> Rob and Mike, could you check if there is no problem in blackberry port ?

Seems it fixes a leak for bb port. Thanks for the patch
Comment 6 Hajime Morrita 2012-12-12 15:52:50 PST 
rs=me base on Yong's comment.
Comment 7 Gyuyoung Kim 2012-12-12 19:59:08 PST 
(In reply to comment #6)
> rs=me base on Yong's comment.

Thank you for your rs. But, when ?
Comment 8 Kentaro Hara 2012-12-12 20:03:10 PST 
Comment on attachment 178930 [details]
Patch

It looks like morrita isn't around now. rs=me.
Comment 9 Hajime Morrita 2012-12-12 20:44:39 PST 
(In reply to comment #8)
> (From update of attachment 178930 [details])
> It looks like morrita isn't around now. rs=me.
Oops sorry. I thought I did this but actually didn't.
Comment 10 WebKit Review Bot 2012-12-12 21:52:45 PST 
Comment on attachment 178930 [details]
Patch

Clearing flags on attachment: 178930

Committed r137568: <http://trac.webkit.org/changeset/137568>
Comment 11 WebKit Review Bot 2012-12-12 21:52:50 PST 
All reviewed patches have been landed.  Closing bug.