Coordinated Graphics: Rename LayerTreeCoordinator to CoordinatedLayerTreeHost
Created attachment 178736 [details] Patch
Comment on attachment 178736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178736&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:73 > + CoordinatedLayerTreeHostProxy* coordinatedLayerTreeHostProxy = webPageProxy->drawingArea()->coordinatedLayerTreeHostProxy(); I think calling the local variable for just layerTreeHostProxy is fine as it is an impl of LayerTreeHostProxy Maybe also do this for the getter if we don't differentiate the two
Created attachment 178752 [details] Patch Refactor QQuickWebPagePrivate to make a cleaner code.
Created attachment 178861 [details] Rebase after r137293
Comment on attachment 178861 [details] Rebase after r137293 This is fine with me, but I'd like someone else that's affected by it (Kenneth?) to look as well and commit.
Comment on attachment 178861 [details] Rebase after r137293 Clearing flags on attachment: 178861 Committed r137358: <http://trac.webkit.org/changeset/137358>
All reviewed patches have been landed. Closing bug.
Comment on attachment 178861 [details] Rebase after r137293 View in context: https://bugs.webkit.org/attachment.cgi?id=178861&action=review > Source/WebKit2/UIProcess/DrawingAreaProxy.h:104 > + OwnPtr<CoordinatedLayerTreeHostProxy> m_coordinatedLayerTreeHostProxy; I was OK with the patch, just wondering whether it would be better to just call this like m_layerTreeHostProxy as we are supposely just a specialized version and most of the places the "coordinated" is obvious > Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:372 > + m_coordinatedLayerTreeHostProxy->didReceiveCoordinatedLayerTreeHostProxyMessage(connection, messageID, decoder); like m_layerTreeHostProxy->didReceiveMessage ? It is almost like double here