Add an optional output to WebViewImpl::selectionBounds to query the order of selection anchor
Created attachment 178703 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 178703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178703&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:2356 > if (!frame->selection()->selection().isBaseFirst()) I'm a little confused here. It looks like anchor and focus are being swapped when isAnchorFirst is false. Is that unnecessary if you are returning isAnchorFirst to the caller? It seems a little odd to apply a transform on the WebKit side but also return the details of the transform.
(In reply to comment #3) > (From update of attachment 178703 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178703&action=review > > > Source/WebKit/chromium/src/WebViewImpl.cpp:2356 > > if (!frame->selection()->selection().isBaseFirst()) > > I'm a little confused here. It looks like anchor and focus are being swapped when isAnchorFirst is false. Is that unnecessary if you are returning isAnchorFirst to the caller? It seems a little odd to apply a transform on the WebKit side but also return the details of the transform. It is used to return start and end but 66973 changed it to anchor and focus, and there is no way for us to query start and end from the embedder side.
Comment on attachment 178703 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.