Bug 104612 – Enhance the TileCache to cache more tiles

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Enhance the TileCache to cache more tiles

[Simon Fraser (smfr)]

Created attachment 178670 [details]
Patch

[Simon Fraser (smfr)]

<rdar://problem/10790464>

[WebKit Review Bot]

Attachment 178670 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:16:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:19:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:22:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:24:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:25:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 7 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 178670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178670&action=review

Yikes!

> Source/WebCore/ChangeLog:72
> +        (WebCore::TileCache::TileCache):
> +        (WebCore::TileCache::~TileCache):
> +        (WebCore::TileCache::setNeedsDisplay):
> +        (WebCore::TileCache::setNeedsDisplayInRect):
> +        (WebCore::TileCache::setTileNeedsDisplayInRect):
> +        (WebCore::TileCache::setScale):
> +        (WebCore::TileCache::setAcceleratesDrawing):
> +        (WebCore::TileCache::setTilesOpaque):
> +        (WebCore::TileCache::prepopulateRect):
> +        (WebCore::TileCache::setTileDebugBorderWidth):
> +        (WebCore::TileCache::setTileDebugBorderColor):
> +        (WebCore::TileCache::computeTileCoverageRect):
> +        (WebCore::TileCache::tileSizeForCoverageRect):
> +        (WebCore::TileCache::tileRevalidationTimerFired):
> +        (WebCore::TileCache::blankPixelCount):
> +        (WebCore::queueTileForRemoval):
> +        (WebCore::TileCache::removeAllTiles):
> +        (WebCore::TileCache::removeAllSecondaryTiles):
> +        (WebCore::TileCache::removeTilesInCohort):
> +        (WebCore::TileCache::revalidateTiles):
> +        (WebCore::TileCache::nextTileCohort):
> +        (WebCore::TileCache::startedNewCohort):
> +        (WebCore::TileCache::newestTileCohort):
> +        (WebCore::TileCache::oldestTileCohort):
> +        (WebCore::TileCache::scheduleCohortRemoval):
> +        (WebCore::TileCache::cohortRemovalTimerFired):
> +        (WebCore::TileCache::ensureTilesForRect):
> +        (WebCore::TileCache::tileGridExtent):
> +        (WebCore::TileCache::tileCoverageRect):
> +        (WebCore::TileCache::tileLayerAtIndex):
> +        (WebCore::TileCache::drawTileMapContents):

This saddens the reviewer.

> Source/WebCore/page/FrameView.cpp:1896
> +    fprintf(stderr, "FrameView::requestScrollPositionUpdate to %d,%d\n", position.x(), position.y());

Is this logging supposed to be here? Seems unlikely.

[Tim Horton]

Comment on attachment 178670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178670&action=review

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:410
> +    if (m_tileCoverage & CoverageForHorizontalScrolling && !largeVisibleRectChange)
> +        coverageHorizontalSize *= 2;
> +
> +    if (m_tileCoverage & CoverageForVerticalScrolling && !largeVisibleRectChange)
> +        coverageVerticalSize *= 3;

Could factor out the if (!largeVisibleRectChange).

[Tim Horton]

Comment on attachment 178670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178670&action=review

> Source/WebCore/platform/graphics/ca/mac/TileCache.h:138
> +        KeepSecondaryTiles,
> +        PruneSecondaryTiles

Is "Secondary" the word we want to go with here?

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/137387