old-run-webkit-tests: add --show-results properly
Created attachment 178657 [details] Patch
Created attachment 178659 [details] fix bug number in comment
Comment on attachment 178659 [details] fix bug number in comment View in context: https://bugs.webkit.org/attachment.cgi?id=178659&action=review > Tools/Scripts/old-run-webkit-tests:362 > - 'show-results' => sub { $launchSafari = 1; }, > + 'show-results!' => sub { $launchSafari = $_[1]; }, You shouldn't need the sub to do this. :) Notice how sample-on-timeout works.
Created attachment 178661 [details] no need for the sub
You're right. Some days I just shouldn't be coding, apparently ...
Comment on attachment 178661 [details] no need for the sub LGTM.
Comment on attachment 178661 [details] no need for the sub Clearing flags on attachment: 178661 Committed r137228: <http://trac.webkit.org/changeset/137228>
All reviewed patches have been landed. Closing bug.