Bug 104608 - old-run-webkit-tests: add --show-results properly
Summary: old-run-webkit-tests: add --show-results properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-10 16:02 PST by Dirk Pranke
Modified: 2012-12-10 17:14 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2012-12-10 16:03 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
fix bug number in comment (1.71 KB, patch)
2012-12-10 16:04 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
no need for the sub (1.70 KB, patch)
2012-12-10 16:07 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-12-10 16:02:16 PST
old-run-webkit-tests: add --show-results properly
Comment 1 Dirk Pranke 2012-12-10 16:03:04 PST
Created attachment 178657 [details]
Patch
Comment 2 Dirk Pranke 2012-12-10 16:04:06 PST
Created attachment 178659 [details]
fix bug number in comment
Comment 3 Eric Seidel (no email) 2012-12-10 16:05:36 PST
Comment on attachment 178659 [details]
fix bug number in comment

View in context: https://bugs.webkit.org/attachment.cgi?id=178659&action=review

> Tools/Scripts/old-run-webkit-tests:362
> -    'show-results' => sub  { $launchSafari = 1; },
> +    'show-results!' => sub  { $launchSafari = $_[1]; },

You shouldn't need the sub to do this.  :)  Notice how sample-on-timeout works.
Comment 4 Dirk Pranke 2012-12-10 16:07:20 PST
Created attachment 178661 [details]
no need for the sub
Comment 5 Dirk Pranke 2012-12-10 16:07:49 PST
You're right. Some days I just shouldn't be coding, apparently ...
Comment 6 Eric Seidel (no email) 2012-12-10 16:12:47 PST
Comment on attachment 178661 [details]
no need for the sub

LGTM.
Comment 7 WebKit Review Bot 2012-12-10 17:14:18 PST
Comment on attachment 178661 [details]
no need for the sub

Clearing flags on attachment: 178661

Committed r137228: <http://trac.webkit.org/changeset/137228>
Comment 8 WebKit Review Bot 2012-12-10 17:14:22 PST
All reviewed patches have been landed.  Closing bug.