Bug 104604 - REGRESSION (r137006): CSS clip on solid color composited div broken
Summary: REGRESSION (r137006): CSS clip on solid color composited div broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-10 15:18 PST by Simon Fraser (smfr)
Modified: 2012-12-10 22:45 PST (History)
5 users (show)

See Also:


Attachments
Testcase (1.31 KB, text/html)
2012-12-10 15:18 PST, Simon Fraser (smfr)
no flags Details
Patch (6.24 KB, patch)
2012-12-10 16:03 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (7.54 KB, patch)
2012-12-10 21:44 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch for landing (7.54 KB, patch)
2012-12-10 22:29 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-12-10 15:18:06 PST
Created attachment 178644 [details]
Testcase

r137006 broke CSS clip in some cases. See attached testcase.
Comment 1 Noam Rosenthal 2012-12-10 16:03:27 PST
Created attachment 178658 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-10 17:52:03 PST
Comment on attachment 178658 [details]
Patch

Attachment 178658 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15238786

New failing tests:
platform/chromium/virtual/softwarecompositing/geometry/clip-inside.html
compositing/geometry/clip-inside.html
Comment 3 Simon Fraser (smfr) 2012-12-10 17:55:45 PST
Comment on attachment 178658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178658&action=review

> LayoutTests/compositing/geometry/clip-inside.html:3
> +<!-- saved from url=(0066)https://bug-104604-attachments.webkit.org/attachment.cgi?id=178644 -->
> +<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

You could clean this up.
Comment 4 Noam Rosenthal 2012-12-10 21:44:31 PST
Created attachment 178706 [details]
Patch
Comment 5 Noam Rosenthal 2012-12-10 22:29:44 PST
Created attachment 178719 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-12-10 22:45:14 PST
Comment on attachment 178719 [details]
Patch for landing

Clearing flags on attachment: 178719

Committed r137250: <http://trac.webkit.org/changeset/137250>
Comment 7 WebKit Review Bot 2012-12-10 22:45:18 PST
All reviewed patches have been landed.  Closing bug.