Bug 104570 – [Coverity] [GTK] Remove some redundant null checks in DumpRenderTree

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Martin Robinson]

We shoul remove some redundant null checks in DumpRenderTree.

[Martin Robinson]

Created attachment 178590 [details]
Patch

[Martin Robinson]

Created attachment 178651 [details]
Patch

[Daniel Bates]

Comment on attachment 178651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178651&action=review

OK. This patch doesn't change the existing functionality. That is, we currently return an empty string for the NSURLRequest portion of the willSendRequest string when soupMessage is null. I'm unclear how some ports came to the decision to return an empty string for the NSURLRequest portion of the willSendRequest string and some ports return a NSURLRequest string with "(none)" for the HTTP method.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1235
> +        path.data(), mainDocumentURIString.data(), soupMessage->method));

For completeness, the Mac and EFL ports return "(none)" when the HTTP method isn't known.

[Martin Robinson]

(In reply to comment #3)

Thanks for the review!

> For completeness, the Mac and EFL ports return "(none)" when the HTTP method isn't known.

Dan Winship, the libsoup maintainer, informs me that the method is "GET" by default for SoupMessages. The only way that it is null is if you manually override it (which as far as I know, we never do). I cannot find any examples of test expectations that "have the (none)" output as well.

[Martin Robinson]

Committed r137300: <http://trac.webkit.org/changeset/137300>

[Martin Robinson]

Committed r137536: <http://trac.webkit.org/changeset/137536>