Bug 104565 - run_webkit_tests throws exception when DRT is not present
Summary: run_webkit_tests throws exception when DRT is not present
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-10 08:31 PST by jochen
Modified: 2012-12-10 13:20 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.12 KB, patch)
2012-12-10 11:22 PST, Dirk Pranke
jochen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-12-10 08:31:07 PST
Unable to find test driver
    at /usr/local/google/home/eisinger/chrome/trunk/src/out/Debug/DumpRenderTree

For complete Linux build requirements, please see:

    http://code.google.com/p/chromium/wiki/LinuxBuildInstructions
Build check failed

TypeError raised: 'NoneType' object has no attribute '__getitem__'
Traceback (most recent call last):
  File "/usr/local/google/home/eisinger/chrome/trunk/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 432, in main
    bot_printer.print_results(run_details)
  File "/usr/local/google/home/eisinger/chrome/trunk/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py", line 52, in print_results
    self.print_unexpected_results(run_details.summarized_results)
  File "/usr/local/google/home/eisinger/chrome/trunk/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py", line 124, in print_unexpected_results
    resultsjsonparser.for_each_test(summarized_results['tests'], add_result)
TypeError: 'NoneType' object has no attribute '__getitem__'
Comment 1 Dirk Pranke 2012-12-10 11:22:42 PST
Created attachment 178597 [details]
Patch
Comment 2 Dirk Pranke 2012-12-10 11:30:58 PST
Committed r137189: <http://trac.webkit.org/changeset/137189>
Comment 3 Eric Seidel (no email) 2012-12-10 12:40:20 PST
I'm seeing:

[1132/1606] webkitpy.layout_tests.run_webkit_tests_integrationtest.MainTest.test_build_check failed:                          
  Traceback (most recent call last):
    File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 890, in test_build_check
      self.assertEqual(run_webkit_tests.main(['--platform', port_name, 'fast/harness/results.html'], out, err), -1)
    File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 419, in main
      port = host.port_factory.get(options.platform, options)
    File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 127, in get
      return cls(self._host, port_name, options=options, **kwargs)
    File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 77, in __init__
      assert self._version in self.SUPPORTED_OS_VERSIONS
  AssertionError
  
Ran 1606 tests in 2.998s    

on my linux box.  I suspect that may be related to this?
Comment 4 Dirk Pranke 2012-12-10 13:17:19 PST
(In reply to comment #3)
> I'm seeing:
> 
> [1132/1606] webkitpy.layout_tests.run_webkit_tests_integrationtest.MainTest.test_build_check failed:                          
>   Traceback (most recent call last):
>     File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 890, in test_build_check
>       self.assertEqual(run_webkit_tests.main(['--platform', port_name, 'fast/harness/results.html'], out, err), -1)
>     File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 419, in main
>       port = host.port_factory.get(options.platform, options)
>     File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 127, in get
>       return cls(self._host, port_name, options=options, **kwargs)
>     File "/src/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 77, in __init__
>       assert self._version in self.SUPPORTED_OS_VERSIONS
>   AssertionError
> 
> Ran 1606 tests in 2.998s    
> 
> on my linux box.  I suspect that may be related to this?

argh, yes. will fix shortly ...
Comment 5 Dirk Pranke 2012-12-10 13:20:49 PST
fix posted in https://bugs.webkit.org/show_bug.cgi?id=104589